253195 - Fix a couple of subtle block reflow bugs

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

While debugging columns I found a couple of really nasty subtle block reflow
bugs. I've finally tracked them down and fixed them. Once you know where to look
the bugs are obvious. I'll attach a patch.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

So there are two bugs. PullFrameFrom doesn't detect the last line correctly
because it looks at the current block instead of the line's container. The more
deadly bug, and the one that took me a really long time to track down, is that
someone thought "lines = flow->mLines", where lines is a nsLineBox&, would
rebind the reference, but it actually just copies the linked list pointers from
one block to another. Errrk.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in. Thanks!