253787 - In <nsContextMenu.js>, "Warning: reference to undefined property docshell.document.charset" (and other warnings/errors)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040714] (release) (W98SE)

{{
Warning: reference to undefined property docshell.document.charset
Source File: chrome://communicator/content/nsContextMenu.js
Line: 642
}}

When clicking on page context menu "Bookmark This Page";
Yet the bookmark is added as expected.

Comment 1

[[e-mail]]

It won't get added correctly if the URL contains non-ascii characters.
In that case, the characterSet is used to correctly decode them.
However the name of the variable appears to have been mistyped in this case.

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE)

Line number changed:
{{
Warning: reference to undefined property docshell.document.charset
Source File: chrome://communicator/content/nsContextMenu.js
Line: 650
}}

Neil:
I try on plain ascii URLs.
I'll try s/charset/characterSet/g ... there are 2 lines.

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE)

Bug already there.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) "xpfe/" <nsContextMenu.js> [Checked in: Comment 5 and 10]

I tested line 652: no more warning, bookmark still added.
I don't know how to test line 663...

Could you test/(super-)review/check in this patch ? Thanks.

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-TB) <nsContextMenu.js> [Checked in: Comment 19]

I don't use TB: Could you test/review/check in this patch ? Thanks.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 168820 [details] [diff] [review]
(Av1) "xpfe/" <nsContextMenu.js>
[Checked in: Comment 5 and 10]

1.7.5 has shipped. Moving request to 1.7.6.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 168907 [details] [diff] [review]
(Bv1-TB) <nsContextMenu.js>
[Checked in: Comment 19]

No review from <[e-mail]> since "2004-12-16" :-(

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 168820 [details] [diff] [review]
(Av1) "xpfe/" <nsContextMenu.js>
[Checked in: Comment 5 and 10]

a=caillon for 1.7.6, but please land this quickly.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 168820 [details] [diff] [review]
(Av1) "xpfe/" <nsContextMenu.js>
[Checked in: Comment 5 and 10]


Check in: { 2005-02-11 16:04	neil%parkwaycc.co.uk	mozilla/ xpfe/
communicator/ resources/ content/ nsContextMenu.js	 1.88.2.1	
MOZILLA_1_7_BRANCH }

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 168907 [details] [diff] [review]
(Bv1-TB) <nsContextMenu.js>
[Checked in: Comment 19]

approval-aviary1.0.2?: already fixed1.7.6...

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Trunk error, not present in v1.0 branch !!?
{{
Error: redeclaration of const kMailToLength
Source File: chrome://communicator/content/nsContextMenu.js
Line: 13
}}
_when starting TB_.

<http://lxr.mozilla.org/mozilla/search?string=kMailToLength>
{{
kMailToLength
/mail/base/content/nsContextMenu.js, line 52 -- const kMailToLength = 7;
/mail/base/content/nsContextMenu.js, line 579 -- if ( qmark > kMailToLength )
/mail/base/content/nsContextMenu.js, line 580 -- addresses = url.substring(
kMailToLength, qmark );
/mail/base/content/nsContextMenu.js, line 582 -- addresses = url.substr(
kMailToLength );
}}
It would seem that this file is loaded more than 1 time at/from a given place...

helpwanted.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Too late for 1.0.2.  Furthermore, if you actually wanted to get this on a
branch, you would need to describe:
 * what real bug (not warning) it was fixing
 * what the risks are (e.g., is it triggering codepaths that weren't previously
exercised, or is it triggering codepaths that were exercised via a different UI
path)

That said, since you seem to nominate way too many patches for branch checkin
(and just make drivers do a lot of extra work for things that obviously don't
need to be on branches), we'd probably just ignore your nomination anyway.

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #13)
> Too late for 1.0.2.  Furthermore, if you actually wanted to get this on a
> branch, you would need to describe:
>  * what real bug (not warning) it was fixing

{{
 ------- Additional Comment #1 From [e-mail]  2004-12-05 15:53 PST 
[reply] -------

It won't get added correctly if the URL contains non-ascii characters.
In that case, the characterSet is used to correctly decode them.
}}

>  * what the risks are (e.g., is it triggering codepaths that weren't previously
> exercised, or is it triggering codepaths that were exercised via a different UI
> path)

Little risk: I guess codepath for charset handling will be triggered where it
was not (lacking the data).

> That said, since you seem to nominate way too many patches for branch checkin
> (and just make drivers do a lot of extra work for things that obviously don't
> need to be on branches), we'd probably just ignore your nomination anyway.

:-(

Comment 15

[Serge Gautherie (:sgautherie)]

Another one:

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20041217] (release) (W98SE)

No bug

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050217] (release) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050317] (nightly) (W98SE)

When right clicking on a text input, like those of a bugzilla bug page
{{
Warning: assignment to undeclared variable type
Source File: chrome://communicator/content/nsContextMenu.js
Line: 294
}}

"Incorrect"'!?) fix from bug 110471, then _leftover_ from bug 245661.

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) <nsContextMenu.js> (undeclared |type|)

Comment 17

[[e-mail]]

Or from bug 196380 for the xpfe version.

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 168907 [details] [diff] [review]
(Bv1-TB) <nsContextMenu.js>
[Checked in: Comment 19]

'approval1.8a2=?':
Trivial JS code cleanup, lo w risk.

Comment 19

[Brian Ryner (not reading)]

Comment on attachment 168907 [details] [diff] [review]
(Bv1-TB) <nsContextMenu.js>
[Checked in: Comment 19]

checked in.

Comment 20

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1a) <nsContextMenu.js> (undeclared |type|) [Checkin: Comment 21]

Cv1, unbitrotted to current trunk,
for checkin.

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 262762 [details] [diff] [review]
(Cv1a) <nsContextMenu.js> (undeclared |type|)
[Checkin: Comment 21]


Checkin: {
2007-04-27 05:26	bugzilla%standard8.demon.co.uk
}

Comment 22

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 2.0.0.4pre (20070427)] (nightly) (W2Ksp4)
[Mozilla Thunderbird, version 3.0a1 (20070427)] (nightly) (W2Ksp4)

(In reply to comment #12)
> Error: redeclaration of const kMailToLength
> _when starting TB_.

Not getting this one anymore.


R.Fixed.