254375 - Object.toSource fails for negative number properties

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

js> eval(uneval({'-1':true}))
typein:187: SyntaxError: invalid property id:
typein:187: ({-1:true})
typein:187: ..^
js> build()
built on Aug  2 2004 at 20:00:51

Comment 1

[Nicholas Allen]

Yes, that's not a valid literal.  Why not quote integers all the time?  It looks
like doubles are already set up that way.

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Always quoting bloats the runtime with atomized strings, instead of int
immediate operands in the bytecode stream that save space.  This patch quotes
only negative integer property ids.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed, fiat review.  Timeless, please nominate for branches if you care.

/be

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 155250 [details] [diff] [review]
fix

a=mkaply for 1.7.3 and aviary if you want it.

Comment 5

[timeless]

Comment on attachment 155250 [details] [diff] [review]
fix

mozilla/js/src/jsobj.c	3.155.2.3

Comment 6

[Brendan Eich [:brendan]]

Fixed on aviary branch too.

/be

Comment 7

[Bob Clary [:bc] (inactive)]

Attachment: js1_5/Regress/regress-254375.js

Again, thanks to timeless.

Comment 8

[Bob Clary [:bc] (inactive)]

js1_5/Regress/regress-254375.js checked in.

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed.