254564 - Buddy icons not shown

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[M.J.G.]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040805 Firefox/0.9.3
Build Identifier: Mozilla Thunderbird 0.7.2 (X11/20040716)

Mailnews/Thunderbird should display buddy icons as described in
http://www.mozilla.org/mailnews/arch/buddyicons.html, i.e. they should show uop
in message view (headers expanded) and card view (addressbook).
Alas, nothing is shown.

Reproducible: Always
Steps to Reproduce:
1. Set up buddy icons (icons and addressbook card) as per
http://www.mozilla.org/mailnews/arch/buddyicons.html
2. Call up message view (expanded) or address card.
3. 

Actual Results:  
No buddy icons are visible. No visual difference to the case without buddy icons.

Expected Results:  
Display buddy icons.

Same in cvs.

Comment 1

[M.J.G.]

Digging into abCardViewOverlay.js, I noticed that a call to XPCOM's directory
service is wrong ("@mozilla.org/directory_service;1" instead of
"@mozilla.org/file/directory_service;1"). The attached patch is a one liner, it
works for me in the addressbook. The patch is against the version from TBird's
0.7.2 source tar ball, but I checked that the current version is still missing
the "/file" part.

The same one-liner as for abCardView works for msgHdrView and implements the
correct behaviour for the message header view.

Comment 2

[M.J.G.]

Attachment: patch to abCardViewOverlay.js (Checked in)

patch to abCardViewOverlay.js from content/messenger/addressbook in mail.jar

Comment 3

[M.J.G.]

Attachment: patch to msgHdrViewOverlay.js (Checked in)

patch to msgHdrViewOverlay.js from content/messenger in mail.jar

Comment 4

[M.J.G.]

This affects components "Mail Window Fron End" and "Addressbook". How do I
specify two components?

Comment 5

[Ian Neal]

Comment on attachment 155353 [details] [diff] [review]
patch to abCardViewOverlay.js
(Checked in)

Changing to someone who will r/sr on mailnews

Comment 6

[Ian Neal]

Comment on attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

Changing to someone who will r/sr on mailnews

Comment 7

[Ian Neal]

Checking in (trunk)
base/resources/content/msgHdrViewOverlay.js; new revision: 1.142; previous
revision: 1.141
addrbook/resources/content/abCardViewOverlay.js; new revision: 1.37; previous
revision: 1.36
done

Comment 8

[Ian Neal]

Comment on attachment 155353 [details] [diff] [review]
patch to abCardViewOverlay.js
(Checked in)

requesting a= for simple, low risk, regression fix

Comment 9

[Ian Neal]

Comment on attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

requesting a= for simple, low risk, regression fix

Comment 10

[Mike Schroepfer]

Comment on attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

Approved for 1.8b5 per bug meeting

Comment 11

[Ian Neal]

Checking in (branch)
addrbook/resources/content/abCardViewOverlay.js; new revision: 1.36.26.1;
previous revision: 1.36
base/resources/content/msgHdrViewOverlay.js; new revision: 1.141.2.1; previous
revision: 1.141
done