254586 - a lot of places assume cacheToken can be qi'd to nsICacheEntryDescriptor

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

the API only guarantees QI-ability to nsICacheEntryInfo.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

hm... this patch does slightly more than cacheentryinfo. but, while I'm here,
I'd like to get that in too, if you don't mind.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 155360 [details] [diff] [review]
patch

unfortunately I could not change all callers, since some need
nsICacheEntryDescriptor :(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 155360 [details] [diff] [review]
patch

r=bzbarsky for all of it, but could you split up the docshell change into two
checkins?  Otherwise the cvs log/blame will be _very_ confusing...

Comment 4

[Darin Fisher]

Comment on attachment 155360 [details] [diff] [review]
patch

sr=darin

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

refcounted views part:
Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.614; previous revision: 1.613
done

cache token part:
Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.613; previous revision: 1.612
done
Checking in modules/libpr0n/src/imgRequest.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgRequest.cpp,v  <--  imgRequest.cpp
new revision: 1.80; previous revision: 1.79
done