Closed Bug 254860 Opened 20 years ago Closed 16 years ago

Add "cc" to supported fields in bug_email.pl

Categories

(Bugzilla :: Bugzilla-General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: davef, Unassigned)

References

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040612 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040612 Firefox/0.8

I needed to have bug_email.pl support a "cc" field, and created a patch to fix
it. I'm testing it now, and will post it shortly, but figured I'd post this bug
to make sure there wasn't a better way to do it, or anything I should be doing
to make it more likely this gets patched. The patch also adjusts the bug_email
documentation (bugmail_help.html) to describe the new field.

Reproducible: Always
Steps to Reproduce:
Here's the decently tested patch. Relatively straightforward, and a nice
addition for folks.
any chance of anyone looking at this? I'd hate to have the patch become useless
because time has passed... 
Attachment #155721 - Flags: review?(kiko)
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Comment on attachment 155721 [details] [diff] [review]
patch to resolve bug

It's unacceptable to have in /contrib code that initializes a hash (%ccids) 
based on $Control{'cc'} and to introduce code redundancy and duplication.

I'd remove said code from post_bug.cgi and move it into one of those
Bugzilla/*.pm files. Then have it called from both bug_email.pm and
post_bug.pm. 

As a nit, SendSQL is depreciated and $dbh-> methods should be used instead.
Attachment #155721 - Flags: review?(kiko) → review-
Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.
Assignee: justdave → general
QA Contact: mattyt-bugzilla → default-qa
Blocks: 322955
This difference handles obtaining the CC in a different manner than was originally applied to this bug. It also has some options for updating bug_email.pl's getEnumList function such that it works with the new Bugzilla 2.20 schema.
I hope this code proves to be useful.
email_in.pl already supports @newcc and @cc. bug_email.pl is dead.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: