255305 - [Approval Queue] UI for the Approval Queue Log

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement)

Description

[alanjstr]

The approval log should be browsable, showing who approved/denied and when they
did it.

Comment 1

[Wolf [:wolf]]

Agreed. :-) This wasn't done originally cause the approval logging is kinda
hackish to start with.

Comment 2

[Wolf [:wolf]]

I've done a basic UI. It's basically a tabular print of the table. Anything more
featured will have to wait till after 1.0.

Comment 3

[Wolf [:wolf]]

A basic UI is in update-beta. I'll consider taking a more complete UI for
update-beta if it gets done, otherwise this is post 1.0. 

Marking assigned as this is part of my fixed-beta list (for the basic UI
anyway). and I don't really see a point in spinning of a new bug for the full thing.

Comment 4

[alanjstr]

I'd like to see pagination and filtering/searching.  I'd prefer it shows Who,
What, When with the ability to click an item to see actual approval/denial
details.  

Comment 5

[Wolf [:wolf]]

Bulk Moving Developer Control Panel bugs to new component.
(Filter: massdevcpspam)

Comment 6

[alanjstr]

Mass-resolving bugs that have been fixed on trunk.

Comment 7

[Wolf [:wolf]]

Sorry for the bugspam, reopening bugs wrongly marked as resolved.

Comment 8

[alanjstr]

The column headers for Install? 	Unistall? 	New Chrome? 	App Works? are useless,
since you have to select YES in order to approve.

Comment 9

[Wolf [:wolf]]

They're not there for YES, they're there for No. :-)

Comment 10

[alanjstr]

But I can't leave a box unchecked, can I?  So it would never be a No

Comment 11

[Wolf [:wolf]]

If you're donig a denial, it can be a no. :-)

Comment 12

[alanjstr]

Instead of ID and vID, how about the name and version with a link to edit it?  

There are no checkboxes for Visual Errors? and All Elements Themed?, so they can
be removed.  

Maybe rename the values in Action as "Approved", "Denied" by wrapping the print
statement with a replace().  Or maybe a smiley, a frowny, and a circle with a
question mark in it.

I'm not sure what uID is supposed to be.  It doesn't appear to be unique.

Comment 13

[Wolf [:wolf]]

Visual Errors / All Elements Themed, as the names suggest are for Themes only.
:-) They don't appear for Extensions.

--> 1.1.

Comment 14

[Cameron]

Now that Firefox and UMO are becoming more popular, the approval log is getting
pretty huge. Ability to view pages of 20 items at a time would be useful.

Comment 15

[Colin Ogilvie [:cso]]

This definetly needs to be improved... I'll work on it by the end of the week.

Comment 16

[Jon Stritar]

I've started to do some work on this. Colin, if you have done anything or have
any  ideas we can coordinate in irc.

Comment 17

[Jon Stritar]

Attachment: Improved approval log UI

Here is what is in this patch:

1) Simplified approval log table which includes important data (removes the
install?, new chrome?, etc columns because the descriptions cover that) and has
borders for easier reading.
2) The log now resolves the IDs to actual extension and user names.
3) Extension and user names are links to edit the user/extension or just to
view the extension (on the moreinfo.php page) if you're not an admin.
4) I've also changed the link in the approval queue to point to the
moreinfo.php for the extension if you do not have privileges to edit it.

CTho: I tried to add more context to the patch, but when I used the actual cvs
command to diff, it thought I changed the entire file... so instead I just made
it with eclipse and the default amount of context.

Comment 18

[alanjstr]

Comment on attachment 192052 [details] [diff] [review]
Improved approval log UI

>@@ -243,79 +256,136 @@
> 
> <?php 
> } else if ($function=="approvalhistory") {
>+
>+function renderPageNav($page, $pages, $per_page) {
>+	$url = "?function=".$_GET['function']."&amp;numpg=".$per_page."&amp;pageid=";

That looks like a function inside a IF block.  Say it aint' so.

Comment 19

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 192052 [details] [diff] [review]
Improved approval log UI

UMO v2 is live.  I had a lot less to do with its development, so check with morgamic before using me for reviews.

Comment 20

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 21

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

v2 didn't have a new queue UI, but we're not going to be fixing the v1 UI either.  WONTFIXing rather than making a strict "WFM" reading of the Summary!