Closed
Bug 255465
Opened 20 years ago
Closed 20 years ago
Ctrl+= should enlarge text in Help viewer
Categories
(SeaMonkey :: Help Viewer, defect)
SeaMonkey
Help Viewer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwalden+fxhelp, Assigned: jwalden+fxhelp)
References
()
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file)
1.77 KB,
patch
|
Details | Diff | Splinter Review |
The problem's simple: in the Help viewer, pressing Ctrl+(plus key on qwerty section of keyboard) doesn't work, while pressing Ctrl+(plus key on NumPad) works. Why? The plus key on the qwerty section isn't really the plus key -- it's the equals (=) key. Test it -- Ctrl+Shift+= will enlarge the text. Firefox and Seamonkey have known about this problem for a while, so they've added a second <key/> element that takes care of the = problem. Patch coming up to do the same for Help...note also that it's a l10n change because I have to add = as an entity, so it needs to get in before PR1.0.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 156003 [details] [diff] [review] Patch Requesting review from rlk...
Attachment #156003 -
Flags: review?(rlk)
Comment 3•20 years ago
|
||
Comment on attachment 156003 [details] [diff] [review] Patch r=rlk@trfenv.com, thanks Jeff! I would like an ID attribute but I guess it isn't necessary.
Attachment #156003 -
Flags: review?(rlk)
Attachment #156003 -
Flags: review+
Attachment #156003 -
Flags: approval-aviary?
Assignee | ||
Comment 4•20 years ago
|
||
(In reply to comment #3) > (From update of attachment 156003 [details] [diff] [review]) > r=rlk@trfenv.com, thanks Jeff! I would like an ID attribute but I guess it > isn't necessary. I was following the style that the main browser uses, which is not to assign an id: http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser-sets.inc#285 I also figured the id would only be useful if it were hooked up to something, as the id is hooked up to the relevant menu item in the main browser.
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•20 years ago
|
||
We're adding an entity for l10n...requesting blocking-aviary1.0PR.
Flags: blocking-aviary1.0PR?
Whiteboard: [have patch]
Updated•20 years ago
|
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Comment 7•20 years ago
|
||
Comment on attachment 156003 [details] [diff] [review] Patch approved. but needs to get in quickly
Attachment #156003 -
Flags: approval-aviary? → approval-aviary+
Assignee | ||
Comment 8•20 years ago
|
||
> (From update of attachment 156003 [details] [diff] [review])
> approved. but needs to get in quickly
Steffen, any chance you can check this in?
Comment 9•20 years ago
|
||
Steffen got it. This is in on the trunk, so fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 10•20 years ago
|
||
Checked in br & trunk. I also added an id key_textZoomEnlarge2 just in case an extension wants to change it.
Updated•19 years ago
|
Flags: review+
Flags: blocking-aviary1.0PR+
Flags: approval-aviary+
Product: Firefox → Toolkit
Target Milestone: Firefox1.0beta → ---
Updated•8 years ago
|
Product: Toolkit → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•