Closed Bug 255465 Opened 20 years ago Closed 20 years ago

Ctrl+= should enlarge text in Help viewer

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jwalden+fxhelp, Assigned: jwalden+fxhelp)

References

()

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

The problem's simple: in the Help viewer, pressing Ctrl+(plus key on qwerty
section of keyboard) doesn't work, while pressing Ctrl+(plus key on NumPad)
works.  Why?  The plus key on the qwerty section isn't really the plus key --
it's the equals (=) key.  Test it -- Ctrl+Shift+= will enlarge the text.

Firefox and Seamonkey have known about this problem for a while, so they've
added a second <key/> element that takes care of the = problem.  Patch coming up
to do the same for Help...note also that it's a l10n change because I have to
add = as an entity, so it needs to get in before PR1.0.
Attached patch PatchSplinter Review
Comment on attachment 156003 [details] [diff] [review]
Patch

Requesting review from rlk...
Attachment #156003 - Flags: review?(rlk)
Comment on attachment 156003 [details] [diff] [review]
Patch

r=rlk@trfenv.com, thanks Jeff! I would like an ID attribute but I guess it
isn't necessary.
Attachment #156003 - Flags: review?(rlk)
Attachment #156003 - Flags: review+
Attachment #156003 - Flags: approval-aviary?
(In reply to comment #3)
> (From update of attachment 156003 [details] [diff] [review])
> r=rlk@trfenv.com, thanks Jeff! I would like an ID attribute but I guess it
> isn't necessary.

I was following the style that the main browser uses, which is not to assign an id:

http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser-sets.inc#285

I also figured the id would only be useful if it were hooked up to something, as
the id is hooked up to the relevant menu item in the main browser.
Status: NEW → ASSIGNED
Not a doc change, so removing bug dependency.
No longer blocks: 253104
We're adding an entity for l10n...requesting blocking-aviary1.0PR.
Flags: blocking-aviary1.0PR?
Whiteboard: [have patch]
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Comment on attachment 156003 [details] [diff] [review]
Patch

approved. but needs to get in quickly
Attachment #156003 - Flags: approval-aviary? → approval-aviary+
> (From update of attachment 156003 [details] [diff] [review])
> approved. but needs to get in quickly

Steffen, any chance you can check this in?
Steffen got it. This is in on the trunk, so fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Checked in br & trunk. I also added an id key_textZoomEnlarge2 just in case an
extension wants to change it.
Keywords: fixed-aviary1.0
Whiteboard: [have patch]
Target Milestone: --- → Firefox1.0beta
Flags: review+
Flags: blocking-aviary1.0PR+
Flags: approval-aviary+
Product: Firefox → Toolkit
Target Milestone: Firefox1.0beta → ---
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: