256657 - new plugin placeholder confusing - "click here to download plugin" doesn't

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(not currently active) Ted Mielczarek]

When a page with missing plugins loads, the new plugin placeholder content says
"click here to download plugin".  Since the plugin installer info bar is already
displayed on page load, clicking does nothing.  If the plugin info bar is
already displayed, clicking on the placeholder should launch the same function
as the "Install Missing Plugins" button.

related to bug 244125  and bug 253046 but I'm not sure if it blocks one of them.

Comment 1

[Colin Ogilvie [:cso]]

If the bar is not displaying, then clicking it does display the bar, but this
does not seem intuitive to me, either.

"Click here to download plugin" implies to me that if I click there, the new
wizard is going to appear - not that a bar is going to appear that I think need
to click on.

Comment 2

[Johnny Stenback (:jst)]

Doron, do you think we should change the wording, or change the UI code to
realize that a user clicked on a broken plugin and launch the wizard w/o showing
the new UI?

Comment 3

[Doron Rosenberg (IBM)]

I have a patch that opens the wizard for only the clicked plugin, requires
253046 to go in first.

Comment 4

[Doron Rosenberg (IBM)]

-> a moi

Comment 5

[Doron Rosenberg (IBM)]

Attachment: clicking on a puzzle piece will try to install the clicked plugin only. Also fixes a license code bug.

Comment 6

[Doron Rosenberg (IBM)]

was checked in as part of 257472

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 157158 [details] [diff] [review]
clicking on a puzzle piece will try to install the clicked plugin only.  Also fixes a license code bug.

a=asa for branch checkin.