Closed
Bug 256845
Opened 20 years ago
Closed 20 years ago
Page Info commandkey is gone on Windows
Categories
(Firefox Graveyard :: Help Documentation, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox1.0beta
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
References
Details
Attachments
(1 file)
|
865 bytes,
patch
|
rjkeller
:
review+
|
Details | Diff | Splinter Review |
It used to be Ctrl+J, but that is now Downloads.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 156972 [details] [diff] [review] Don't show the Page Info row on Windows I see no reason to show this row on Windows without having a key.
Attachment #156972 -
Flags: review?(rlk)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 156972 [details] [diff] [review] Don't show the Page Info row on Windows > </tr> > - <tr> > + <tr class="noWin"> > <td>Page Info</td> > - <td><kbd>Ctrl</kbd>+<kbd class="win">J</kbd><kbd > - class="noWin">I</kbd></td> > + <td><kbd>Ctrl</kbd>+<kbd>I</kbd></td> > <td> </td> > <td><kbd>Ctrl</kbd>+<kbd>8</kbd></td> > </tr> If you have noWin as the <tr>, then the hotkey will never be shown when you're on windows, so the win is useless in the <kbd> tag.
Attachment #156972 -
Flags: review?(rlk) → review-
|
|
Assignee | |
Comment 4•20 years ago
|
||
Comment on attachment 156972 [details] [diff] [review] Don't show the Page Info row on Windows > so the win is useless in the <kbd> tag That's why I removed it :) - <td><kbd>Ctrl</kbd>+<kbd class="win">J</kbd><kbd - class="noWin">I</kbd></td> + <td><kbd>Ctrl</kbd>+<kbd>I</kbd></td>
Attachment #156972 -
Flags: review- → review?
|
|
Assignee | |
Comment 5•20 years ago
|
||
Comment on attachment 156972 [details] [diff] [review] Don't show the Page Info row on Windows See comment 4.
Attachment #156972 -
Flags: review? → review?(rlk)
|
|
||
Comment 6•20 years ago
|
||
Comment on attachment 156972 [details] [diff] [review] Don't show the Page Info row on Windows oh yeah, my bad :). I should get some sleep sometime soon. r=rlk@trfenv.com
Attachment #156972 -
Flags: review?(rlk) → review+
|
|
Assignee | |
Comment 7•20 years ago
|
||
Checked in br & trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta
|
||
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•