257154 - Apply fix in bug 217640 to Password manager for list sort exact match

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Tracy Walker [:tracy]]

please refer to bug 271640.

Password manager exhibits the same behavior as Form/Autocomplete in removing
exact matched items in the list of entries.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

I'm pretty sure this will fix it, need to test a bit though.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 159920 [details] [diff] [review]
patch

r+a=[e-mail]

Comment 3

[Brian Ryner (not reading)]

checked into trunk and branch.

Comment 4

[Tracy Walker [:tracy]]

Typing in an exact match in a login field (password manager handled) does show
the list up to the exact match.

But, I'm reopening this bug because of the following issue:

Typing beyond an exact match, then deleting the overtypage back to an exact
match does not show the autofill list.  

note:Deleting one more character (one character short of an exact match) does
then show the autocomplete list. Which is expected.

With form manager, deleting overtypage back to an exact match shows the
autocomplete list as expected. 

Comment 5

[Tracy Walker [:tracy]]

note:  To test this correctly, the login field and its associated password must
have been previously submitted and saved by password manager. That makes the
password manager handle the login field, not the form manager.

Comment 6

[Brian Ryner (not reading)]

Attachment: patch for backspace problem

Thanks. This should fix the backspacing case.

Comment 7

[Asa Dotzler [:asa]]

This bug seems to have an aviary branch checkin associated with it. If this has
landed on the aviary branch (as much as it's going to for 1.0) can you please
add the "fixed-aviary1.0" keyword? Thanks.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 161723 [details] [diff] [review]
patch for backspace problem

r=jst

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 161723 [details] [diff] [review]
patch for backspace problem

a=asa for aviary checkin.

Comment 10

[Brian Ryner (not reading)]

Checked in on the branch.  Leaving bug open until the second patch lands on the
trunk (when the tree reopens).

Comment 11

[sairuh (rarely reading bugmail)]

the password mgr case in comment 4 now looks like it's working --tested with
2004102508-0.9+ on linux fc2.

Comment 12

[Brian Ryner (not reading)]

checked in on trunk.