Closed Bug 257985 Opened 20 years ago Closed 19 years ago

History Window: View|Sorted by menu items do not work

Categories

(Core Graveyard :: History: Global, defect)

Product:
Core Graveyard
Component:
History: Global
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Stefan.Borggraefe, Assigned: vhaarr+bmo)

Details

(Keywords: fixed-seamonkey1.0, regression)

Attachments

(1 file, 2 obsolete files)

version 0.2
2.28 KB, patch
janv
: review+
neil
: superreview+
Details | Diff | Splinter Review 
Instead when you select one of them, the following error is displayed on the
JavaScript Console:

Error: column.parentNode has no properties
Source File: chrome://global/content/nsTreeSorting.js
Line: 67

Tested with a Linux trunk build from yesterday.
Attached patch Proposed Fix (obsolete) — — Splinter Review 

    
  

        Attachment #157847 -
        Flags: review?(varga)

    
    

    
  
The problem is that nsTreeSorting.js was initially developed as a generic
utility, IIRC.
So you shouldn't use |document.getElementById('historyTree')|


    
  

        Attachment #157847 -
        Flags: review?(jan) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        version 0.1 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #157847 -
        Attachment is obsolete: true

        Attachment #197528 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 197528 [details] [diff] [review]
version 0.1

I'm wondering whether we should rename SortColumn to SortColumnElement and add
a new SortColumn method to handle the history tree.

        Attachment #197528 -
        Flags: review?(neil.parkwaycc.co.uk) → review?(Jan.Varga)

    
    

    
  
(In reply to comment #4)
> (From update of attachment 197528 [details] [diff] [review] [edit])
> I'm wondering whether we should rename SortColumn to SortColumnElement and add
> a new SortColumn method to handle the history tree.
> 

Yeah, SortColumn() will just call document.getElementById() and SortColumnElement()

r=varga

    
  

        Attachment #197528 -
        Flags: review?(Jan.Varga) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        version 0.2
        — 
          — Splinter Review
      

    


  
Something like this?
Assignee: Stefan.Borggraefe → vhaarr+bmo
Status: NEW → ASSIGNED

        Attachment #198582 -
        Flags: superreview?(neil.parkwaycc.co.uk)

        Attachment #198582 -
        Flags: review?(Jan.Varga)

    
  

        Attachment #197528 -
        Attachment is obsolete: true

    
  

        Attachment #198582 -
        Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

    
    

    
  
Comment on attachment 198582 [details] [diff] [review]
version 0.2

yes

        Attachment #198582 -
        Flags: review?(Jan.Varga) → review+

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
    

    
  
Seamonkey-only portion of fix checked in to the 1.8 branch.
Whiteboard: fixed-seamonkey1.0
Keywords: fixed-seamonkey1.0
Whiteboard: fixed-seamonkey1.0

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: