258013 - incompatible disabled extensions can be reenabled

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Asa Dotzler [:asa]]

If the app disables extensions as being incompatible after an app upgrade, they
can be re-enabled without warning in the EM. We should prevent this or give a
very clear warning that doing so is ill advised.

Comment 1

[Asa Dotzler [:asa]]

If we're going to need new strings, we'll want to get this ASAP. Setting to
blocking to get on Ben's radar. 

Comment 2

[Austin Sherrin]

I agree that there should be a warning. But I disagree that it should be
disallowed. After changing to the Sept 3rd nightly all but 2 of my extensions
were disabled. After manually enabling the other 8 or so, all worked flawlessly. 

Comment 3

[Doug Wright]

YES for warning. NO for disabling the re-enabling.

Comment 4

[amano]

Seconded. Maybe a message like this might do the trick:

"There is a good chance that this extension was disabled automatically because
of compatibility reasons. Re-enabling the extension can cause problems or might
not work at all, because the extension was NOT tested with this version of
Firefox. Are you sure that you want to try to re-enable the extension anyway?
[No] [Yes]" 

Or something like that.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Prevent extensions disabled because of incompatibilities from being re-enabled,
and show some visual feedback in the EM.

Comment 6

[Asa Dotzler [:asa]]

I've verified this in the windows branch build from 09/06

Comment 7

[Grey Nicholson (they/them)]

Can you explain the rationale behind the choice to completely disallow
re-enabling "incompatible" extensions? Why would a simple warning, perhaps
mentioning how to start Firefox in Safe Mode, be insufficent?