258787 - Personal Toolbar: Not all context menu items are available when right clicking

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marcia Knous [:marcia]]

Comment 1

[Marcia Knous [:marcia]]

Seen while testing Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3)
Gecko/20040910 Firefox/0.10. Affects all platforms.

STR:

1. Launch a fresh instance of the browser.
2. Place cursor in personal toolbar area and then right click to launch context
menu.
3. Observe that numerous menu selections are grayed out and not available for
selection.

I create new folders quite a bit in the personal toolbar and would expect that I
could do so by clicking anywhere in the personal toolbar area. Also, if you
click on an existing bookmark it seems as if it enables the entire context menu.

Tracy and I are investigating if this is a regression.

Comment 2

[Tracy Walker [:tracy]]

I narrowed this regression down to a window of between the builds on
2004-08-17-08 and 2004-08-18-08

specifically, the context menu items that regressed are:
-New Bookmark...
-New Folder...
-New Seperator...

In addition to Marcia's comments.  These items in the context menu remain
enabled until restart.  On Restart they are again grey out.  Before the
regression, on restart, these item would not be greyed out.

Comment 3

[Marcia Knous [:marcia]]

Still seeing this behavior on Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
en-US; rv:1.7.3) Gecko/20040928 Firefox/0.10. When I right click on the personal
toolbar, all menu items are grayed out except for Expand | Open in tabs |Manage
Folder |Properties.

Sarah reports she also is seeing this in today's Linux build and I just verified
that this is happening on Windows XP as well.

Comment 4

[Marcia Knous [:marcia]]

nominating.

Comment 5

[Tracy Walker [:tracy]]

Any new window shows the bug.  

workaround to get the menu items to appear is to context click an existing
bookmark in the bookmark toolbar.  From then on, that window will have the
proper items available.

Comment 6

[chris hofmann]

vlad, is there a way to fix this regression?

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 258787-ptf-not-all-items-available-0.patch

This is somewhat of a bandaid, but a working one; right-clicks on the ptf
portion don't go through BookmarksMenu.js, so we don't get the _target/aTarget
setting that we'd normally get for the controller.  So, the PTF gets special
cased here.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 262924 has been marked as a duplicate of this bug. ***

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 161093 [details] [diff] [review]
258787-ptf-not-all-items-available-0.patch

r+a=[e-mail]

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

fixzored on aviary.

Comment 11

[Tracy Walker [:tracy]]

Verified with Mac build 2004-10-05-06-0.9