261273 - Changing columns does not work with Sun ONE Web Server version 6.1

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[tmabbott]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913
Build Identifier: Bugzilla v 2.18rc2

Changing columns was not working for us - no matter what you selected it would
allways display the default.

We are using SunOne (v6.1) web server as the front end.  After a fair bit of
messing around I noticed some special handeling for ISS in "colchange.cgi",
specifically it does the following:


    if ($ENV{'SERVER_SOFTWARE'} =~ /Microsoft-IIS/) {
      print $cgi->header(-type => "text/html",
                         -refresh => "0; URL=$vars->{'redirect_url'}");
    } else {
      print $cgi->redirect($vars->{'redirect_url'});
    }

 From reading a little about bug 214466 (mentioned in the comments) this has to
do with NPH (no-parse-headers) and how the web server deals with them(??)

Anyhow - if I allow it to detect SunOne with this:

    if ( ($ENV{'SERVER_SOFTWARE'} =~ /Microsoft-IIS/ ) ||
         ($ENV{'SERVER_SOFTWARE'} =~ /Sun ONE Web/ ) ) {
      print $cgi->header(-type => "text/html",
                         -refresh => "0; URL=$vars->{'redirect_url'}");
    } else {
      print $cgi->redirect($vars->{'redirect_url'});
    }
...

for our setup (SunOne 6.1 on Solaris), then change columns works - otherwise, no
dice. 

The full string of the environment variable $ENV{'SERVER_SOFTWARE'} for our
installation is "Sun ONE Web Server/6.1"





Reproducible: Always
Steps to Reproduce:
1. Install bugzilla behind Sun ONE web server v6.1
2. try changing columns on a bug list resulting from a query.

Actual Results:  
you get a page with the default coluns (the COLUMNLIST cookie is not set).

Expected Results:  
changed the columns...

Comment 1

[Dave Miller [:justdave]]

This is pretty low-risk, let's see if we can get it in 2.18

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Here's a patch based on the solution provided in the bug description.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 159911 [details] [diff] [review]
patch v1: fixes problem

Dave, can you review this trivial fix.	Reporter, can you verify that this
patch fixes the problem for you?

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 159911 [details] [diff] [review]
patch v1: fixes problem

doesn't break apache :)  If Tim likes it, it's good with me.

Comment 5

[Dave Miller [:justdave]]

reassigning to code contributor
a=justdave for 2.18 and trunk

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Reporter, thanks for the fix!  Checked in on trunk and 2.18 branch:

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.41.2.1; previous revision: 1.41
done
Checking in ../bztip/colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.43; previous revision: 1.42
done

Comment 7

[tmabbott]

(this is the Reporter)

Verified - Columns now change as expected, and this doesn't appear to break
anything.

Thanks!