261707 - Links with empty href don't get a focus outline when they are focused

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20040925 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20040925 Firefox/0.9.1+

A link like this:
<a href="">Link</a>
doesn't get a focus outline anymore, when you focus it.

This is a regression.
This used to work in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040724
Firefox/0.9.1+
But it doesn't work anymore as of:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040726
Firefox/0.9.1+

Also when you tab through to the link, normally you get to be shown the link
href in the status bar. This is also not happening with the empty href testcase.
This might sound a bit strange, but an empty href 'gets' automatically the
current location.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Martijn Wargers (dead)]

It could be a regression from bug 250006, but I'm not sure.

Comment 3

[Martijn Wargers (dead)]

I've tried adding this style rule to the testcase:
<style>a[href=""]:focus{-moz-outline:1px dotted black;}
</style>
But the style rule somehow doesn't get applied (no focus outline when focusing
the link) 

Comment 4

[Boris Zbarsky [:bzbarsky]]

This is absolutely a regression from bug 250006.   The check
nsHTMLAnchorElement::IsFocusable does for an empty URI is totally bogus.  It
should be getting the HrefURI and checking whether that's null.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Oh, and that bug broke tabbing to and focusing of XLinks too.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase for XLink

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 160598 [details] [diff] [review]
Proposed patch

sr=jst

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Note:  When I checked this in, two bits of the bug 263200 patch made it in too
(the nsHTMLAnchorElement.cpp and nsXMLElement.cpp bits).

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; focus ring is now present in build 2004-11-17-04 using testcase
https://bugzilla.mozilla.org/attachment.cgi?id=160187&action=view on Windows XP
with Seamonkey trunk.