262030 - unnamed bookmarks makes extra margins on the right

Status: RESOLVED DUPLICATE of bug 479439

(Firefox :: General, defect)

Description

[Sekundes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a4) Gecko/20040927
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a4) Gecko/20040927

I have some unnamed bookmarks with favicon to acts like a button when clicking
in the Bookmarks Toolbar. However, it has extra margins when hovering which
makes it non-square and makes it ugly. I appreciate everyone who can solve this
issue as I don't have any tools to work on CVS.

Reproducible: Always
Steps to Reproduce:
1. Create a bookmark without Name.
2. Move your mouse on that bookmark inside the Bookmarks Toolbar.
3. It has extra right margins when hovering which makes it quite ugly.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040928
Firefox/0.10

Confirming
it's about 2 px spacing between icon/text causing it

Comment 2

[miahz]

I can fix this.  Should be a pretty simple patch.  A similar problem affects the
Link Toolbar in icons only mode, as well as some of the DOMI buttons.

Comment 3

[miahz]

Attachment: patch: fix extra space on labelless bookmarks - simple fix

This removes the margins from the icons on toolbar bookmarks (and folders) with
no labels (Names).  This is quite a hackish fix, but it fulfills the letter of
the bug request.  A better, though more complicated, real fix to the underlying
problem will follow...

Diff'ed off [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3)
Gecko/20041017 Firefox/1.0].

Comment 4

[miahz]

Comment on attachment 162416 [details] [diff] [review]
patch: fix extra space on labelless bookmarks - simple fix

Harmless little polish for bookmarks.  What do you think?

Comment 5

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 6

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.