262422 - Build fails with Binutils version 2.15.91

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Vidhya]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.1.4322)
Build Identifier: 

I followed all the steps in http://www.mozilla.org/build/win32.html

And regarding the tools i'm using mingw gcc/binutils:

binutils-2.15.91-20040904-1, gcc-core-3.3.3-20040217-1 ,
gcc-g++-3.3.3-20040217-1,
mingw-runtime-3.3 , w32api-2.5.

My mozset.bat(to set environmental variables).

set MOZ_TOOLS=c:\mozilla\moztools
set MOZCONFIG=c:\mozilla\mozilla\mymozconfig.mozconfig
set PATH=c:\mozilla\mingw\bin;c:\cygwin\bin;%MOZ_TOOLS%\bin;%PATH
set HOME=c:\mozilla

My mozconfig is:

CC=gcc
CXX=g++
CPP=cpp
AS=as
LD=ld
ac_add_options --disable-accessibility
ac_add_options --enable-debug
ac_add_options --disable-optimize


when trying to run make -f client.mk build_all from command prompt
got the compilation errors as in the attached document.

I think its a new bug with the binutils version 2.15.91

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Vidhya]

Attachment: Build Log

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 261761 has been marked as a duplicate of this bug. ***

Comment 3

[Daniel Ross]

I also have this problem. I identified it as being caused by the following two
lines:

#137: ".type  " SYMBOL_UNDERSCORE "_XPTC_InvokeByIndex,@function\n"

#197: ".size " SYMBOL_UNDERSCORE "_XPTC_InvokeByIndex, . -" SYMBOL_UNDERSCORE
"_XPTC_InvokeByIndex\n\t"



I am using binutils-2.15.91-20040904-1 as well, with gcc-core-3.4.2-20040916-1,
gcc-g++-3.4.2-20040916-1, mingw-runtime-3.5, and w32api-3.1

Comment 4

[Daniel Ross]

Also, I'm using Windows XP and attempting to build Firefox.

Comment 5

[cls]

Attachment: Remove .type & .size for win32

Not sure if this is a problem for non-win32 builds or not but we don't seem to
be using the proper format for .type & .size.  Per the warnings that we've been
seeing forever, mingw binutils expects those to be inside .def/.endef blocks. 
This patch removes their use for win32 completely.

Comment 6

[chris hofmann]

not sure we would block on this, but go ahead and get it in in the next few days.
'thanks

Comment 7

[David Bradley]

cls, I'm not a super reviewer. I don't mind reviewing it.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 160885 [details] [diff] [review]
Remove .type & .size for win32

r+sr=dmose; sorry for the delay

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 160885 [details] [diff] [review]
Remove .type & .size for win32

a=asa for checkin to branches.

Comment 10

[cls]

Patch has been checked into the trunk, 1.7 & aviary branches.

Comment 11

[Daniel Ross]

Shouldn't it have the keyword for being fixed on Aviary as well?

Comment 12

[Asa Dotzler [:asa]]

This bug seems to have an aviary branch checkin associated with it. If this has
landed on the aviary branch (as much as it's going to for 1.0) can you please
add the "fixed-aviary1.0" keyword? Thanks.