Closed Bug 262821 Opened 20 years ago Closed 19 years ago

outputFilters should receive message destination as a parameter

Categories

(Other Applications :: ChatZilla, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jjfoerch, Assigned: rginda)

References

Details

(Whiteboard: [cz-patch][cz-0.9.68])

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.3) Gecko/20040913
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.3) Gecko/20040913

outputFilters receive as parameters the message to be filtered and the message
type (like PRIVMSG).  Filters are useful for things like spell checkers and
colorizers.  Yet people will often want to condition the filtering on the
destination of the message.  I wrote a colorizer script and it was brought to my
attention that messages directed to bots like ChanServ or Nickserv should not be
filtered by the colorizer.  Plus netiquette dictates that some channels don't
want people to colorize their text.  In order to implement this condition, it
seems necessary that the outputFilter functions receive a third parameter for
the destination of the message.

Reproducible: Always
Steps to Reproduce:
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Core → Other Applications
Attachment #180940 - Flags: review?(rginda)
Whiteboard: cz-patch
Whiteboard: cz-patch → [cz-patch][cz-0.9.68]
Blocks: 299458
Comment on attachment 180940 [details] [diff] [review]
Add dest parameter

Seems fine :-)

rginda, could you review this? Would be another bit of 0.9.68 getting into
trunk cvs.
Attachment #180940 - Flags: review+
Comment on attachment 180940 [details] [diff] [review]
Add dest parameter

r=rginda
Attachment #180940 - Flags: review?(rginda) → review+
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: