264009 - Focus remains in the menu after middleclick

Status: RESOLVED INCOMPLETE

(Firefox :: Menus, defect)

Description

[Dorando]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10

.

Reproducible: Always
Steps to Reproduce:
1. Set following prefs:
browser.tabs.loadBookmarksInBackground to true
browser.tabs.loadFolderAndReplace to false
2. Goto a page with scrollbar ( http://planet.mozilla.org/ ).
3. Make sure the content has focus (try scrolling via keyboard)
4A. Middleclick on Help->Promote Firefox
4B. Middleclick on Bookmarks->Bookmarks Toolbar Folder->Getting Started
4C. Middleclick on Bookmarks->Bookmarks Toolbar Folder
5. Press Down (VK_DOWN)

Actual Results:  
The previously used menu opens.


Expected Results:  
The view of the original tab should scroll.

Comment 1

[Dorando]

Attachment: patch against aviary

Comment 2

[Mike Connor [:mconnor]]

I'm away from Mozilla for the near to medium future, please try to find another
reviewer.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 161852 [details] [diff] [review]
patch against aviary

I'd much prefer using .focus() instead of synthesizing left click events that
didn't happen.	Can you get that to work?

Comment 4

[Dorando]

Attachment: double .focus() instead of .click()

Seems to have the same effect.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 167420 [details] [diff] [review]
double .focus() instead of .click()

Ok, we shouldn't need both window.focus() and window._content.focus().	Just
doing the second one should be sufficient.  Does that work?

Comment 6

[Dorando]

(In reply to comment #5)
> Ok, we shouldn't need both window.focus() and window._content.focus().	Just
> doing the second one should be sufficient.  Does that work?
> 
Sadly not. Only the first one is able to close the menu, but the focus seems to
get lost. Note, that the .click(); returned the focus to the previous selected
object, while the .focus(); always focuses the content.

It would likely be better to change whatever causes the menu to close on left
clicks to also do this on middle click.

Comment 7

[Brian Ryner (not reading)]

cc'ing aaronl, who has done some work with that menu code iirc

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 167420 [details] [diff] [review]
double .focus() instead of .click()

minusing to get off of my review list... sounds like the approach of causing
the menu to close on middle click the same way it closes on left click would be
preferable.

Comment 9

[Kevin Brosnan]

WFM-  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

Firefox's top level menus are unresponsive to middle clicks now.

Comment 10

[Tyler Downer [He/Him]]

This bug was reported on Firefox 2.x or older, which is no longer supported and will not be receiving any more updates. I strongly suggest that you update to Firefox 3.6.3 or later, update your plugins (flash, adobe, etc.), and retest in a new profile. If you still see the issue with the updated Firefox, please post here. Otherwise, please close as RESOLVED > WORKSFORME
http://www.mozilla.com
http://support.mozilla.com/kb/Managing+profiles
http://support.mozilla.com/kb/Safe+mode

Comment 11

[Tyler Downer [He/Him]]

No reply, INCOMPLETE. Please retest with Firefox 3.6.x or later and a new profile (http://support.mozilla.com/kb/Managing+profiles). If you continue to see this issue with the newest firefox and a new profile, then please comment on this bug.