264085 - text field of bookmarkfolder gets editable if selected and expanded

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[florian]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041011 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041011 Camino/0.8+

Just switched from Safari to Camino, loved it and found the first bug:-)

If you select a bookmarkfolder and stay with the mousepointer over it the
bookmark textfield gets editable. That's normal.
But if you select a bookmarksfolder and expand the view so that the content gets
visible the bookmarks text field also gets visible. Even if you move the mouse
pointer away. I think thats a bug.
It doesn't happen if the bookmarks folder is not selected.

But i'm still in love :-)

Reproducible: Always
Steps to Reproduce:
1. Open Bookmarkmanager (Command + B)
2. Select the Bookmarks Bar or Menu
3. Click on a folder and move the mouse away. Nothing happens
4. Expand the folder by clicking on the triangle

Actual Results:  
-> The text field of the bookmarks folder gets editable


Expected Results:  
The bookmarks folder should stay selected but not become editable.

Comment 1

[florian]

This doesn't happen if the bookmarks folder is expanded via keys.

But it also happend in Camino 0.8.1.

Comment 2

[Martijn Wargers (dead)]

*** Bug 264084 has been marked as a duplicate of this bug. ***

Comment 3

[Jasper]

Confirming bug using 2004100808 (v0.8+) NB on 10.3.5

It's non destructive but a bit strange. The Finder doesn't have this issue in
list view. Apperently we are registring the secod click on the expand triangle
while we shouldn't do that.

Comment 4

[Mike Pinkerton (not reading bugmail)]

this has been around for a while, it'll be good to get it fixed but 1.0 is
prolly ok.

Comment 5

[Simon Fraser [no longer active]]

This bugs me.

Comment 6

[Mike Pinkerton (not reading bugmail)]

bugs me too, just never got a chance to look at it.

Comment 7

[Simon Fraser [no longer active]]

Attachment: Patch

The bug was that [ExtendedOutlineView mouseDown:] was being too lax when
looking at the location of the click. This patch requires the click to be on
the text part of the cell.

Comment 8

[Simon Fraser [no longer active]]

Attachment: Patch

The bug was that [ExtendedOutlineView mouseDown:] was being too lax when
looking at the location of the click. This patch requires the click to be on
the text part of the cell.

Comment 9

[Simon Fraser [no longer active]]

Sorry about the double attachment: bugzilla slowness.
Fixed on trunk and branch.