266103 - IT/sv/ru/pl not included in regionNames.properties

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Ervin Yan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.7) Gecko/20041004
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.7) Gecko/20041004

dowload all spellchecking modules from:
http://dictionaries.mozdev.org/

Reproducible steps:
1. start Mozilla composer
2. click menu "Edit|Check Spelling"
3. click "Language:" combo box.

You will see it-IT/sv-SE/ru-RU/pl-PL not translated.

which means need include IT/sv/ru/pl in file: 
xpfe/global/resources/locale/en-US/regionNames.properties


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Ervin Yan]

Attachment: patch to include it/pl/ru/se in regionNames.properties

Comment 2

[Simon Montagu :smontagu]

Thank you for the patch. Please patch also toolkit/locale/regionNames.properties
and attach a contextual diff (made with diff -u).

Comment 3

[Ervin Yan]

Attachment: new patch

Comment 4

[Ervin Yan]

Comment on attachment 163512 [details] [diff] [review]
new patch

could you review the patch?

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 163512 [details] [diff] [review]
new patch

r=smontagu

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 163512 [details] [diff] [review]
new patch

The rest of the file uses tabs, so please use tabs.  Otherwise, sr=dbaron,
although please check with bsmedberg before landing because of the aviary
branch merging.

Comment 7

[Ervin Yan]

Attachment: patch to follow dbaron's comments.

Comment 8

[Benjamin Smedberg]

In addition to the two places already listed, please also land this patch in

toolkit/locales/en-US/chrome/global/regionNames.properties

Comment 9

[Ervin Yan]

Attachment: patch to follow bsmedberg's comments

Comment 10

[Ervin Yan]

bsmedberg: do you have any other concerns for landing this patch?

Comment 11

[Benjamin Smedberg]

It looks fine to me.

Comment 12

[Ervin Yan]

Attachment: patch to follow the latest change in cvs trunk

toolkit/locale/regionNames.properties is removed in latest trunk.

Comment 13

[Ervin Yan]

patch landed. thanks simford.dong for help to check in the patch.