266242 - Remove (some) #ifdefs from GTK classic

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[[e-mail]]

As per bug 251492 it may be possible to remove the #ifdefs from
classic/global/unix/checkbox.css and radio.css and classic/global/win/menu.css -
so far I only tried checkbox.css and I don't see any regressions.

Comment 1

[Ginn Chen]

Attachment: patch

patch to remove #ifdefs in classic/global/unix/checkbox.css, radio.css
and some #ifdefs in classic/global/win/menu.css.
Not tested yet.

I think we could not remove all the #ifdefs in classic/global/win/menu.css yet.

Comment 2

[[e-mail]]

Comment on attachment 163548 [details] [diff] [review]
patch

radio.css and checkbox.css look fine to me with GTK1 although I haven't had a
chance to test the changes to menu.css yet.

Comment 3

[Ginn Chen]

Attachment: patch v2

revised and tested on Fedora Core 3 gtk build

Comment 4

[Ginn Chen]

Checking in themes/classic/jar.mn;
/cvsroot/mozilla/themes/classic/jar.mn,v  <--  jar.mn
new revision: 1.129; previous revision: 1.128
done
Checking in themes/classic/global/unix/checkbox.css;
/cvsroot/mozilla/themes/classic/global/unix/checkbox.css,v  <--  checkbox.css
new revision: 1.14; previous revision: 1.13
done
Checking in themes/classic/global/unix/radio.css;
/cvsroot/mozilla/themes/classic/global/unix/radio.css,v  <--  radio.css
new revision: 1.13; previous revision: 1.12
done
Checking in themes/classic/global/win/menu.css;
/cvsroot/mozilla/themes/classic/global/win/menu.css,v  <--  menu.css
new revision: 1.56; previous revision: 1.55
done