266375 - Crash on restart of Firefox 1.0 RC1 after updating from Firefox 0.10.1 - FF10RC1 [@ msvcrt.dll | jpins7.dll | jpioji.dll - nsJVMManager::StartupJVM] [@ MSVCRT.DLL - nsPluginHostImpl::GetPluginFactory]

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Jared Smith]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

After using Software Update to upgrade Firefox 0.10.1 to Firefox 1.0 RC1,
Firefox refuses to start and crashes instead.  See Talkback TB1561554Q for an
example of crash data.

Reproducible: Always
Steps to Reproduce:
1. Change app.update.url to
http://update.mozilla.org/update/firefox/en-US-1.0-rc.rdf
2. Run Software Update to upgrade to Firefox 1.0 RC1
3. Restart Firefox and see the crash

Actual Results:  
Crash in firefox.exe in msvcrt.dll.  Event viewer says: Faulting application
firefox.exe, version 1.0.0.0, faulting module msvcrt.dll, version 7.0.2600.2180,
fault address 0x00037c7e.

Expected Results:  
Started Firefox 1.0 RC1 without problems

Faulting application firefox.exe, version 1.0.0.0, faulting module msvcrt.dll,
version 7.0.2600.2180, fault address 0x00037c7e.

Comment 1

[sairuh (rarely reading bugmail)]

http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB1561554Q

msvcrt.dll + 0x37c7e (0x77c47c7e)
jpins7.dll + 0x188f (0x6d35188f)
nsJVMManager::StartupJVM 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/modules/oji/src/nsJVMManager.cpp,
line 655]
nsJVMManager::MaybeStartupLiveConnect 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/modules/oji/src/nsJVMManager.cpp,
line 876]
NS_CreateScriptContext 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/dom/src/base/nsJSEnvironment.cpp,
line 2013]
nsDOMScriptObjectFactory::NewScriptContext 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/dom/src/base/nsDOMScriptObjectFactory.cpp,
line 82]
nsWebShell::GetInterface 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/docshell/base/nsWebShell.cpp,
line 299]
nsGetInterface::operator() 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/xpcom/glue/nsIInterfaceRequestorUtils.cpp,
line 53]
nsCOMPtr_base::assign_from_helper 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/xpcom/glue/nsCOMPtr.cpp,
line 114]
nsAppShellService::GetHiddenWindowAndJSContext 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/xpfe/appshell/src/nsAppShellService.cpp,
line 932]
nsAppShellService::SetXPConnectSafeContext 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/xpfe/appshell/src/nsAppShellService.cpp,
line 202]
nsAppShellService::CreateHiddenWindow 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/xpfe/appshell/src/nsAppShellService.cpp,
line 485]
xre_main 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/toolkit/xre/nsAppRunner.cpp,
line 1826]
main 
[d:/builds/tinderbox/firefox-1.0/WINNT_5.0_Clobber/mozilla/browser/app/nsBrowserApp.cpp,
line 58]
kernel32.dll + 0x16d4f (0x7c816d4f)

Comment 2

[sairuh (rarely reading bugmail)]

out of curiosity I went through the steps to repro this on linux fc2 (from using
1.0PR), but the software update wizard wouldn't complete. after downloading the
Firefox browser, the wizard said:

Problems During Update: Firefox encountered problems when updating your
software, and as a result not all components could be updated. [Details]

clicking the Details button brought up a dialog with a xml parsing error (the
titlebar said "Gecko"):

XML Parsing Error: undefined entity
Location: chrome://mozapps/content/update/error.xul
Line Number 10, Column 16:

title="&errors.title;"
-------^

possible l10n issue, or something else?

in any case, the software update didn't succeed (but no crashing).

Comment 3

[sairuh (rarely reading bugmail)]

forgot to add: the version of 1.0PR I've got has app.version = 0.10.1.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

*** Bug 266379 has been marked as a duplicate of this bug. ***

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently there are other 179 incident reports with nearly the same stack trace:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=msvcrt.dll+%2B+0x37c7e+%280x77c47c7e%29&vendor=All&product=All&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid

Comment 6

[Oscar van Vliet]

Tried it on Mac without crash. I am using Steven Michaud's JEP 0.86 plugin. That
crashed on my banking site (doesn't do that in Mozilla).

But the update feature cycled through and presented a civilised dialog window
informing me there were no updates.

Comment 7

[Nitin (vfwlkr)]

*** Bug 266401 has been marked as a duplicate of this bug. ***

Comment 8

[Tobias Sager]

Have this issue on W2k SP4 as well.
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=1569548

Comment 9

[Robin Monks]

*** Bug 266428 has been marked as a duplicate of this bug. ***

Comment 10

[Simone Chiaretta]

Attachment: Installation Log

The installation log shows an error during installation

Comment 11

[Simone Chiaretta]

Here are my talkback reports, but I suppose they are the same as everyone's

TB1570569H
TB1570583K
TB1570591W
TB1570602G
TB1570646Y
TB1570673H

Comment 12

[Simone Chiaretta]

This is the "important" part of the installation log I think
-------------------------------------------------------------------------------
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.0rc1/windows-xpi/en-US.xpi
 --  2004-10-28 12:14:56
-------------------------------------------------------------------------------

     ** initInstall: platformNode=win
     en-US Langpack (version 1.0)
     --------------
     ** initInstall: 0
     ** fProgram: C:\Program Files\Mozilla Firefox\
     ** addDirectory() returned: 0
     ** fTarget: C:\Program Files\Mozilla Firefox\defaults\
     ** addDirectory() returned: 0
     ** fTarget: C:\Program Files\Mozilla Firefox\searchplugins\
     ** addDirectory() returned: 0
     [1/101]	Replacing: C:\Program Files\Mozilla Firefox\searchplugins\eBay.src
     [2/101]	Replacing: C:\Program Files\Mozilla Firefox\searchplugins\eBay.src
     [3/101]	Installing: C:\Program Files\Mozilla Firefox\browserconfig.properties
     [4/101]	Replacing: C:\Program Files\Mozilla Firefox\browserconfig.properties

....

     [97/101]	Register Locale: jar:resource:/chrome/en-US.jar!/locale/necko/
     [98/101]	Register Locale: jar:resource:/chrome/en-US.jar!/locale/autoconfig/
     ** InstallLocale() failed. - nsresult code: 0x80004005
     ** InstallPackage() failed. - nsresult code: 0x80004005
     ** Failed to register chrome. - nsresult code: 0x80004005
     ** performInstall() returned: -239

     Install **FAILED** with error -239  --  2004-10-28 12:15:04

Comment 13

[Simone Chiaretta]

Maybe I found why the installation raised the error:

in the en-US.xpi file, in the install.js there is the following command:

registerChrome(chromeType, cf, "locale/autoconfig/");

but there is no local/autoconfig/ folder in the en-US.jar

Comment 14

[Robin Monks]

*** Bug 266524 has been marked as a duplicate of this bug. ***

Comment 15

[Jay Patel [:jay]]

This is a major topcrash for Firefox 1.0 RC1 and the latest Talkback data is
posted in bug 266524.

Comment 16

[Jay Patel [:jay]]

I was able to reproduce this crash on WinXP, but oddly Talkback isn't coming up.
Firefox simply won't launch...I keep getting the WinXP crash dialog instead of
Talkback. Here is what I did:

1. Installed FF 1.0 PR1 and ran it once with an existing profile
2. Changed the update url in about:config to:
http://update.mozilla.org/update/firefox/en-US-1.0-rc.rdf
3. Ran update from the options menu
4. Restarted Firefox... can't get it to startup at all.

Ben:  Is that .rdf file correct?  Any other update urls to try to see if this
crash goes away?

Comment 17

[Jeff Walden [:Waldo]]

> I was able to reproduce this crash on WinXP, but oddly Talkback isn't coming up.
... 
> 1. Installed FF 1.0 PR1 and ran it once with an existing profile

If by any chance you didn't do a custom install, you won't always get Talkback.
 It's enabled/installed with a default installation only a certain percentage of
the time (either 10% or 25%, methinks).  Custom installs with Talkback selected
will always get Talkback.

Comment 18

[Steuard Jensen]

After attempting to update Firefox 0.10.1 on Windows 98, I have not experienced
anything that seems like an actual crash (and as far as I recall, the update
process appeared to be successful).  However, Firefox now refuses to start at
all.  When I try to run it, I just get a small title-less window that reads:

   XML Parsing Error: undefined entity
   Location: chrome://browser/content/browser.xul
   Line Number 910, Column 33:

                         chromedir="&locale.dir;">
   ---------------------------------^

Closing that window closes the program.

I've looked at my install.log file, and the relevant portion is essentially
identical to what is shown in comment #12 (only the installation time differs as
far as I can tell).  I have no idea why I'm getting this XML error instead of a
full-fledged crash (Win 98 vs. Win XP?), but the browser doesn't work either
way.  Are there plans for Software Update to eventually recognize an "Install
**FAILED**" result like this and back out the changes?  (Yes, that probably
belongs in a separate bug.)

In case it's relevant, at the same time as the RC1 update I also asked to update
the Quality Feedback Agent and the Document Inspector, which were listed as
having available updates under "Optional Components".

Comment 19

[Kyle Yuan]

I have the same experience with Steuard - the update seems to be failed, a bunch
of libraries are missing in the component directory, such as gklayout.dll.
Firefox can't start even without java plugin installed.

Comment 20

[Robin Monks]

chromedir="&locale.dir;">

should have been

chromedir="&locale.dir;">

Comment 21

[Benjamin Smedberg]

Robin, you are completely wrong, and this bug isn't about the entity error anyway.

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Kyle, this is a static build, so there is no gklayout.dll... the firefox.exe
executable is about 6-7MB which contains almost everything. 

Comment 23

[Kyle Yuan]

Oh sorry, I didn't notice that. I just tried it again - installed 1.0PR, no java
plugin, update to 1.0rc1, then I got the exactly same error message described in
comment 18. BTW, if the java plugin installed, I did get the same crash as
comment 0 said.

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Only attempt to register chrome for autoconfig when it's being built. The
standalone installer seems not to care about errors being returned, but the in
place installer sure does, and it bails.

Comment 25

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. 

Comment 26

[Asa Dotzler [:asa]]

Comment on attachment 163926 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 27

[sairuh (rarely reading bugmail)]

I tried this on linux fc2, and after the components are downloaded the software
update wizard says that it's unable to complete the update. The Details button
reveals an error saying that the Firefox Browser (read only) could not be
downloaded.

is this expected? I did use the same app.update.url string specified in comment
0 --perhaps that's out of date?

Tracy, what do you see on WindowsXP today?

Comment 28

[Tracy Walker [:tracy]]

still crashes on restart following steps in comment 0.

http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB1706002G

Comment 29

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Tracy, your FF build ID shows 2004100109 which isn't a todays build. You have to
test it with a most recent build. Have you done that and only the ID is wrong?

Comment 30

[Tracy Walker [:tracy]]

Henrik, testing app update with the most recent build is pointless.

This bug is about updating Firefox the Application from the 1.0 PR build of
September to the current 1.0RC1 build.  But it seems that didn't work as
expected.  It only updated to the security 1.0.1 release of Oct 1st. then
crashed on restart. Is this URL,
http://update.mozilla.org/update/firefox/en-US-1.0-rc.rdf, from the steps to
reproduce still valid for this to be tested with? 

Comment 31

[Tracy Walker [:tracy]]

Ah, Ben just explained to me how to have the latest build fool the server by
changing app.version to 0.9.3.  The update mechanism works on the latest Windows
build.  (although it also *updated* to the 1.0.1 build)  No crash now.

Resolving again.

Offering a humble appology to Henrik.  


Marcia is seeing hang in update.  I believe that is different mac bug than this.

sorry about the noise.

Comment 32

[sairuh (rarely reading bugmail)]

following tracy's info (setting today's build app.version == 0.9.3), I can get
this work on linux fc2: it updates it to use 1.0PR (0.10.1). a bit of an odd
"downgrade" but it shows that the software app update mechanism does work on
windows and linux.

Comment 33

[Tracy Walker [:tracy]]

verified Windows FF build 2004-11-04-06-0.11

Comment 34

[Steffen Wilberg]

*** Bug 266339 has been marked as a duplicate of this bug. ***