266637 - Cannot switch to default theme when in safe mode

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Radek 'sysKin' Czyz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

If your current theme is broken, you cannot start FF in normal mode but can
start it in safe mode, which is designed to let you recover from such problem.
However, you cannot change, uninstall or otherwise disable a broken theme.

Reproducible: Always
Steps to Reproduce:
[abstract way]
1. Imagine that your non-default theme is broken and you cannot start firefox
2. Start in safe mode. Browser starts with default theme, so use theme manager
to disable or unistall the offending theme, or otherwise recover from the problem

[real-life way]
1. backup your profile ;)
2. install Pinball 0.9.9.1 from u.m.o
3. observe that you are in *big* trouble
4. start in safe mode. Browser works, so use theme manager to disable or
unistall pinball, or otherwise recover from the problem
Actual Results:  
In safe mode, it is not possible to switch themes or unistall offending theme

Expected Results:  
You can switch to default theme. In fact, how about being able to switch to
*any* theme, it's just a configuration change anyway.

Comment 1

[Tracy Walker [:tracy]]

In safe mode, you should launch in the default theme and should not be able to
switch to other themes. That's the point of safe mode, where themes are
concerned.  I was able to uninstall other themes in safemode. note: selecting
the theme to be deleted doesn't highlight it; just click it then click uninstall.

marking wfm

Comment 2

[alanjstr]

Doesn't WFM 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050418
Firefox/1.0.3 (MOOX M3)

Comment 3

[alanjstr]

More specifically, I can't switch to the default theme, because even THAT one is
disabled.

Comment 4

[Robert Strong (they/them - no direct email)]

This is WFM since the patch for bug 293548 was checked in. I also tested by
selecting a theme other than the default theme, restarting, restarting in safe
mode, selecting use theme for the default theme, and restarted again with the
result of the default theme being the one used.

Resolving WFM