Closed
Bug 26719
Opened 25 years ago
Closed 24 years ago
Memory leak mozilla/widget/src/windows/nsFileWidget.cpp
Categories
(Core :: XUL, defect, P3)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bns_robson, Assigned: jud)
Details
(Keywords: memory-leak, Whiteboard: [nsbeta3+][need info]How big a leak is this?)
Attachments
(1 file)
704 bytes,
patch
|
Details | Diff | Splinter Review |
Memory leak mozilla/widget/src/windows/nsFileWidget.cpp function nsFileWidget::GetFolder calls the Win32 API function ::SHBrowseForFolder which returns a pointer of type LPITEMIDLIST. This is at line 326. I believe the caller is responsible for freeing the memory pointed to. This is not happening.
Comment 1•25 years ago
|
||
reassigning to sdagley. Steve, if this is non-trivial please let me know.
Assignee: trudelle → sdagley
Reporter | ||
Comment 2•25 years ago
|
||
http://support.microsoft.com/support/kb/articles/Q179/3/78.ASP shows use of SHGetMalloc to get the shell’s IMalloc interface and use of this interface to free the result returned from SHBrowseForFolder.
Comment 3•25 years ago
|
||
Keywords: mlk
Comment 4•25 years ago
|
||
*IGNORE* - massive spam changing open XPToolkit bug's QA contact to jrgm@netscape.com
QA Contact: paulmac → jrgm
Comment 6•24 years ago
|
||
Mass-moving all M16 non-feature bugs to M17, which we still consider to be part of beta2
Target Milestone: M16 → M17
Comment 7•24 years ago
|
||
moving to m18, since it is reported as minor
Whiteboard: How big a leak is this?
Target Milestone: M17 → M18
Keywords: patch
Comment 8•24 years ago
|
||
mass-moving all bugs to m21 that are not dofood+, or nsbeta2+
Target Milestone: M18 → M21
Updated•24 years ago
|
Whiteboard: How big a leak is this? → [nsbeta3-][need info]How big a leak is this?
Target Milestone: M21 → M19
Assignee | ||
Comment 10•24 years ago
|
||
I'll apply the patch.
Whiteboard: [nsbeta3-][need info]How big a leak is this? → [nsbeta3+][need info]How big a leak is this?
Assignee | ||
Comment 11•24 years ago
|
||
fix is in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 12•24 years ago
|
||
verified that patch is in with version 3.37 in the tree. Marking VERIFIED
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•