26795 - [MLK] Leaking nsAttributeContent objects

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Patrick C. Beard]

If you look at the blame URL above, I believe that the main reference held by the 
content variable is never released, which it should be because textFrame->Init() 
grabs another reference to content. With the following patch, the leak seems to 
go away:

Index: mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,v
retrieving revision 1.347
diff -c -2 -r1.347 nsCSSFrameConstructor.cpp
*** nsCSSFrameConstructor.cpp	2000/02/04 03:16:47	1.347
--- nsCSSFrameConstructor.cpp	2000/02/07 07:15:33
***************
*** 681,687 ****
          nsresult rv = NS_ERROR_FAILURE;
          if (nsnull != attrName) {
!           nsIContent* content = nsnull;
            nsIFrame*   textFrame = nsnull;
!           NS_NewAttributeContent(&content);
            if (nsnull != content) {
              nsCOMPtr<nsIAttributeContent> 
attrContent(do_QueryInterface(content));
--- 681,687 ----
          nsresult rv = NS_ERROR_FAILURE;
          if (nsnull != attrName) {
!           nsCOMPtr<nsIContent> content;
            nsIFrame*   textFrame = nsnull;
!           NS_NewAttributeContent(getter_AddRefs(content));
            if (nsnull != content) {
              nsCOMPtr<nsIAttributeContent> 
attrContent(do_QueryInterface(content));

Comment 1

[rods (gone)]

Thansk for the patch - fixed

Comment 2

[Chris Petersen]

Marking verified fixed per last comments.