268721 - [firefox] da-DK build still contains old Firefox Crew Picks bookmarks

Status: RESOLVED FIXED

(Mozilla Localizations :: da / Danish, defect)

Description

[sairuh (rarely reading bugmail)]

found using recent (20041109) Firefox 1.0 da-DK builds on all platforms. when
you create a new profile, the default bookmarks contains a folder of the old
Crew Picks links which should be removed --or at least changed to better fit the
needs of the localized build.

in the en-us build (and many other locales), this was addressed in bug 266457.

Comment 1

[Axel Hecht]

we need to get this fixed for 1.0

Comment 2

[Søren Munk Skrøder (extended hiatus)]

Attachment: Removes the Crew picks from the da-DK locale

Comment 3

[Søren Munk Skrøder (extended hiatus)]

Attachment: Removes Crew Picks + Translation into danish

- Crew Picks
+ Translation of current bookmarks
+ Addition of www.mozilladanmark.dk (mozilla denmark) - the joint webpage for
the danish mozilla translation groups (Suite, Firefox, Thunderbird)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 165763 [details] [diff] [review]
Removes Crew Picks + Translation into danish

This file looks like it was UTF-8, but was then converted from ISO-8859-1 to
UTF-8.	(It looks correct in UTF-8 after piping through |iconv -f utf-8 -t
iso-8859-1|.)

Comment 5

[Søren Munk Skrøder (extended hiatus)]

Attachment: Removes Crew Picks, Translates content, is encoded correctly

same as above - but now with proper encoding cf. dbarons posting...

Comment 6

[Axel Hecht]

(In reply to comment #3)
> Created an attachment (id=165763)
> Removes Crew Picks + Translation into danish
> 
> - Crew Picks
> + Translation of current bookmarks
> + Addition of www.mozilladanmark.dk (mozilla denmark) - the joint webpage for
> the danish mozilla translation groups (Suite, Firefox, Thunderbird)

There are least a few links in the bookmarks that should point to danish pages.
http://www.mozilla-europe.org/da/products/firefox/start/central.html is one
of them. You probably know better than me which else.
I'm personally concerned about the user experience of translating link 
descriptions for english pages. Rafael is as well, IIRC.
The link to mozilladanmark is fine with me, but that's just my personal opinion.
But please put in the links as they finally show up, in this particular case
with a trailing slash.

Comment 7

[Axel Hecht]

Comment on attachment 165786 [details] [diff] [review]
Removes Crew Picks, Translates content, is encoded correctly

I prefer -u diffs, too.
I can read those without thinking about the format by now.

Comment 8

[Søren Munk Skrøder (extended hiatus)]

Axel :    (and please read this as an expression of wondering - and not as an 
attack of any sort...)

"I'm personally concerned about the user experience of translating link 
descriptions for english pages. Rafael is as well, IIRC." >>

I need some deeper explenation of that -- what should be wrong with translating 
the descriptions of the "Quick Searches" into danish -- if they remained in 
english, I doubt many people would use them - or at least for me it would seem 
odd to translate the titles of the bookmarks - but not to translate the 
description/usage guide.... 

We may be misunderstanding eachother here... But we/i'm as concerned about 
bringing the best user experience to the users as you are - so this concern 
about us translating description is certainly not one, i fully understand or 
share...

As for the Moz-Euro ... i'm sorry to say, but unfortunately i think it's a two-
way thing -- perhaps we haven't noticed that Mozilla Europe was "that 
important" to put in the bookmarks, since only three pages have been 
translated - and from what i read in the previous bugs and heard on #l10n - it 
more seemed optional that compulsory to include it... I would have wished 
MozEurope had done a greater job of informing us that MozEurope indeed should 
be listed in the bookmarks... -- i can't help but feeling a bit "Do! -or die"-
about it now...

I hope that Søren Christensen can take the issue up tonight as i'm not home 
before tomorrow evening or early monday -- and i would be sorry to hear that 
our release "once again" should be postponed over what from my point of wiev 
sounds like formalia... 

So to play the dumb guy for a moment :   __PLEASE__ tell us what to change so 
that we finally can get this out the door...

/Søren

PS: the diff -u issue :: the patch can still be used right ? -- cmp knows my 
problem with generating this patch -- It's made via WinCVS since, for no know 
reason, i could "convince" my CygWin shell to make it... 

Comment 9

[Axel Hecht]

My only point is, you link to english pages that are translated to danish.
Like central. That's unfortunate. Use pages on danish where available.
On the other hand, you have links to sites that are not translated, but you use
a danish title for those. I'd at least expect to see an "foo (english)" or (en) 
there, so that users see that they're heading off to an english site.

Rafael? Do you have an opinion on this, too?

Comment 10

[Søren Munk Skrøder (extended hiatus)]

Attachment: Yet another patch for Bookmarks.html

Same as above - with these changes 
* is made via cvs diff -u for improved readability
* has link to Firefox Central on mozilla-europe
* all links pointing to english ressources has been marked (engelsk) 
* added link to danish edition of Wikipedia (with keyword "wpdk") but kept
english as well, since it's more complete - danish wikipedia only contains some
20.000 entries

/Søren Munk Skrøder

Comment 11

[Axel Hecht]

Comment on attachment 165904 [details] [diff] [review]
Yet another patch for Bookmarks.html

Please make the link in the personal toolbar link to central (as in en-US, but
to the danish translation).

Remove the link to firefox/start, that is just yet another link to the english
product page.

With that, a=me

Comment 12

[Søren Munk Skrøder (extended hiatus)]

Attachment: Final patching of bookmarks.html

Created new patch which collects all needed changes to bookmarks.html into one
file

Content is as above - but with Firefox Central now in the Toolbar and /start
removed ...

In my mind, this new patch should render attch: 165904 obsolete as it contains
all the changes needed for the entire duration of the bug.... --- this in spite
of the fact that there is given approval for the forementioned patch...

(( in my mind i cant quite understand that one can approve a patch and at the
same time request that the patch be changed - perhaps because i'm fairly new to
this - compared to many other, more routined localizers...))

/Søren Munk Skrøder

Comment 13

[Søren Munk Skrøder (extended hiatus)]

Comment on attachment 165904 [details] [diff] [review]
Yet another patch for Bookmarks.html

Patch rendered obsolete - attch: 165934 is the patch to be used

/Søren Munk Skrøder

Comment 14

[Søren Munk Skrøder (extended hiatus)]

Checking in mozilla/browser/locales/da-DK/profile/bookmarks.html;
/l10n/mozilla/browser/locales/da-DK/profile/Attic/bookmarks.html,v  <-- 
bookmarks.html
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 15

[Marek Stępień [:marcoos, inactive]]

Resolved, per comments on #l10n.