269266 - Create/maintain Mac OS X pinstripe theme for Sunbird

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

I have already begun adding pieces to pinstripe to make Sunbird more Mac-like.

I will attach patches here to continue filling out the pinstripe theme.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - Changes arrows to use OS X style triangles, changes Sunbird to use Mac OS X system font

The four triangle graphics must also be checked in for this patch to work.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: leftTriangle graphic

Check in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/leftTriangle.png

Comment 3

[Matthew (lilmatt) Willis]

Attachment: leftTriangle graphic dark

This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/leftTriangleSelected.png

Comment 4

[Matthew (lilmatt) Willis]

Attachment: rightTriangle graphic

This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/rightTriangle.png

Comment 5

[Matthew (lilmatt) Willis]

Attachment: rightTriangle graphic dark

This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/datetimepickers/rightTriangleSelected.png

Comment 6

[Mostafa Hosseini]

Any reason filenames should be changed?

Comment 7

[Mostafa Hosseini]

Comment on attachment 165625 [details] [diff] [review]
rev0 - Changes arrows to use OS X style triangles, changes Sunbird to use Mac OS X system font

Checked in with filename change

Comment 8

[Mostafa Hosseini]

Comment on attachment 165626 [details]
leftTriangle graphic

Checked in as left-arrow.png

Comment 9

[Mostafa Hosseini]

Comment on attachment 165627 [details]
leftTriangle graphic dark

checked in as left-arrow-hover.png

Comment 10

[Mostafa Hosseini]

Comment on attachment 165628 [details]
rightTriangle graphic

Checked in as right-arrow.png

Comment 11

[Mostafa Hosseini]

Comment on attachment 165629 [details]
rightTriangle graphic dark

checked in as right-arrow-hover.png

Comment 12

[Matthew (lilmatt) Willis]

Attachment: Screenshot - New large icons for Sunbird pinstripe theme

Screenshot of the new Sunbird pinstripe toolbar icons, large version.

Comment 13

[Matthew (lilmatt) Willis]

Attachment: rev0 - new toolbar icon coordinates for pinstripe

You must check in toolbar-large.png and toolbar-small.png for this patch to
work

Comment 14

[Matthew (lilmatt) Willis]

Attachment: rev0 - pinstripe themed large toolbar icons

This should be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/toolbar-large.png

Comment 15

[Matthew (lilmatt) Willis]

Attachment: rev0 - pinstripe themed small toolbar icons (incomplete)

This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/toolbar-small.png

There are still some winstripe icons to replace, but this is all the Photoshop
work I'm doing tonight ;)

Comment 16

[Matthew (lilmatt) Willis]

Attachment: rev1 - pinstripe themed small toolbar icons (complete)

This must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/toolbar-small.png

I finished this set. Ok to review

Comment 17

[Matthew (lilmatt) Willis]

Attachment: pageupdown.png from winstripe

Must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/pageupdown.png

Comment 18

[Matthew (lilmatt) Willis]

Attachment: prevnextarrow.png from winstripe

Must be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/prevnextarrow.png

Comment 19

[Matthew (lilmatt) Willis]

Attachment: rev0 - removes remaining dependencies on winstripe -- pinstripe is now self sufficient

If all the above attachments are approved and checked in, this is the last
patch needed to separate pinstripe from winstripe

Comment 20

[Matthew (lilmatt) Willis]

Comment on attachment 166008 [details] [diff] [review]
rev0 - removes remaining dependencies on winstripe -- pinstripe is now self sufficient

Wrong attachment attached.

Comment 21

[Matthew (lilmatt) Willis]

Attachment: rev1 - removes remaining dependencies on winstripe -- pinstripe is now self sufficient

This patch, in addition to the above patches, removes any remaining
dependencies on winstripe.

Comment 22

[Matthew (lilmatt) Willis]

Attachment: rev1 - new icon coordinates - needed for toolbar icons

Patch sets new icon coordinates. 
pinstripe is 32x32@72ppi and 24x24@72ppi while winstripe is 24x24@100ppi and
16x16X100ppi

Also removes mouseover darkening for Mac. Not appropriate.

Comment 23

[Mostafa Hosseini]

Comment on attachment 165943 [details]
rev0 - pinstripe themed large toolbar icons

Checked in.

Comment 24

[Mostafa Hosseini]

Comment on attachment 166001 [details]
rev1 - pinstripe themed small toolbar icons (complete)

Checked in.

Comment 25

[Mostafa Hosseini]

Comment on attachment 166006 [details]
pageupdown.png from winstripe

Checked in.

Comment 26

[Mostafa Hosseini]

Comment on attachment 166007 [details]
prevnextarrow.png from winstripe

Checked in.

Comment 27

[Mostafa Hosseini]

Comment on attachment 166011 [details] [diff] [review]
rev1 - removes remaining dependencies on winstripe -- pinstripe is now self sufficient

Checked in.

Comment 28

[Mostafa Hosseini]

Comment on attachment 166128 [details] [diff] [review]
rev1 - new icon coordinates - needed for toolbar icons

Checked in. Thanks for all the patches.

Comment 29

[Matthew (lilmatt) Willis]

Attachment: rev0 - patch to enable overriding MozCal's orange "chasing arrows" graphic

Comment 30

[Matthew (lilmatt) Willis]

Attachment: rev0 - New Mac-style "chasing arrows" graphic

Should be checked in as:
mozilla/calendar/sunbird/themes/pinstripe/sunbird/synch_animated.gif

Needs preceeding attachment to include it

Comment 31

[Mostafa Hosseini]

Comment on attachment 166615 [details] [diff] [review]
rev0 - patch to enable overriding MozCal's orange "chasing arrows" graphic

Checked into trunk and branch

Comment 32

[Mostafa Hosseini]

Comment on attachment 166616 [details]
rev0 - New Mac-style "chasing arrows" graphic

Checked into trunk and branch

Comment 33

[Matthew (lilmatt) Willis]

Calling this done.