269994 - Submitting a blank search string to the Dictionary.com search plugin doesn't navigate to the main page

Status: VERIFIED FIXED

(Firefox :: Search, defect, P5)

Description

[David Morgan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.7.5) Gecko/20041110 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.7.5) Gecko/20041110 Firefox/1.0

All other selections in the listing when chosen and then ENTER is pressed, they
go to the website concerned.  With Dictionary.com - nothing happens.  So I then
type in www.dictionary.com and things work.

Reproducible: Always
Steps to Reproduce:
1.Select Dictionary.com by using the down arrow in the Search engine selection box
2.Press Enter
3.Nothing happens.  Appears to need the link inserting somewhere.

Actual Results:  
I remained on the URL page quote above which is
https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox&format=guided

Expected Results:  
Visited website page http://www.dictionary.com

Can't think that anymore information is available to me.

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 274732 has been marked as a duplicate of this bug. ***

Comment 2

[Phil Ringnalda (:philor)]

Indeed, you're right, nothing happens. Which is odd, since nothing's very odd
about dictionary.src, and the code's all straightforward. If there's nothing
typed, then search.xml just gets the host from the
action="http://www.dictionary.com/search" and loads that, and although
www.dictionary.com redirects to dictionary.reference.com, the eBay action
redirects too, and it works with nothing typed.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: Add in dummy string

This just ensures that GetInputs returns something. This allows
GetInternetSearchURL to actually return, so that we can extract the host from
it and load it.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Just like Seamonkey :).
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js#1152

Comment 5

[:Gavin Sharp [email: [e-mail]]]

That line is now:
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js#1168

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 168843 [details] [diff] [review]
Add in dummy string

whee, ugly.

Comment 7

[Asaf Romano (gone)]

Checking in search.xml;
/cvsroot/mozilla/browser/base/content/search.xml,v  <--  search.xml
new revision: 1.22; previous revision: 1.21
done

Comment 8

[PikeUK]

I don't know if there's a bug about fixing the root cause. FWIW in the small sample of search plugins I looked at, this bug happened only with plugins that contained exactly one <input> tag.