Closed Bug 270729 Opened 20 years ago Closed 20 years ago

XPCNativeWrapper doesn't exist on 1.4 branch security fix bustage

Categories

(SeaMonkey :: UI Design, defect)

1.4 Branch
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jon, Assigned: jag+mozilla)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

The fix checked in to the 1.4 branch on 10/28 for bug 249332 is dependent upon
XPCNativeWrapper, which doesn't exist.

(At least middle click pasting of URLs into the content area and middle clicking
to open a link in a new tab is broken as a result.  Error message is displayed
in the JS console: XPCNativeWrapper is not defined ...)

Adding XPCNativeWrapper is minor.  Patch coming up.
Attached patch proposed fixSplinter Review
Add XPCNativeWrapper, and include it from files that include
contentAreaClick.js.
Attachment #166404 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #166404 - Flags: review?(jag)
Severity: normal → major
Comment on attachment 166404 [details] [diff] [review]
proposed fix

That's odd - trunk gets away with including it in contentAreaContextOverlay.xul
which doesn't itself include contentAreaClick.js
(In reply to comment #2)

Including it from contentAreaContextOverlay.xul only seems fine for the browser
but XPCNativeWrapper isn't defined for messageWindow or p3pSummary.  (It seems 
this behavior exists in 1.7 and trunk, bug 267378, also a result of bug 249332.)
Comment on attachment 166404 [details] [diff] [review]
proposed fix

r/a=caillon for 1.4 only
Attachment #166404 - Flags: review?(jag) → review+
Comment on attachment 166404 [details] [diff] [review]
proposed fix

r=jag (or sr, up to Neil).
Product: Core → Mozilla Application Suite
Comment on attachment 166404 [details] [diff] [review]
proposed fix

Trunk seems to have the includes in different files but whatever works...
Attachment #166404 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
v.

Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: