Closed
Bug 270814
Opened 20 years ago
Closed 19 years ago
Configure pass CFLAGS instead of CXXFLAGS to C++-compiler
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: joel, Assigned: cls)
Details
Attachments
(1 file)
526 bytes,
patch
|
cls
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; rv:1.7.3) Gecko/20040917 Firefox/0.10.1 Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; rv:1.7.3) Gecko/20040917 Firefox/0.10.1 When the topmost configure runs the configure-script in the nsprpub-directory, the CFLAGS is passed to the C++-compiler instead of the CXXFLAGS. This is due to a typo in the topmost configure. Suggested fix: *** mozilla/configure.in~ 2004-11-19 16:56:34.133524138 +0100 --- mozilla/configure.in 2004-11-19 16:56:05.487715703 +0100 *************** *** 65,71 **** _SUBDIR_CXX="$CXX" _SUBDIR_CFLAGS="$CFLAGS" _SUBDIR_CPPFLAGS="$CPPFLAGS" ! _SUBDIR_CXXFLAGS="$CFLAGS" _SUBDIR_LDFLAGS="$LDFLAGS" _SUBDIR_HOST_CC="$HOST_CC" _SUBDIR_HOST_CFLAGS="$HOST_CFLAGS" --- 65,71 ---- _SUBDIR_CXX="$CXX" _SUBDIR_CFLAGS="$CFLAGS" _SUBDIR_CPPFLAGS="$CPPFLAGS" ! _SUBDIR_CXXFLAGS="$CXXFLAGS" _SUBDIR_LDFLAGS="$LDFLAGS" _SUBDIR_HOST_CC="$HOST_CC" _SUBDIR_HOST_CFLAGS="$HOST_CFLAGS" Reproducible: Always Steps to Reproduce: 1. 2. 3. Actual Results: % gmake -f client.mk build_all ..... ..... creating xpcom/xpcom-private.h configuring in nsprpub running /usr/local/bin/bash ./configure --enable-js-ultrasparc --disable-tests --disable-debug --enable-optimize=-xO4 --enable-postscript --disable-xprint --disable-ldap --disable-mailnews --disable-composer --enable-xft --disable-freetype2 --enable-x11-shm --enable-image-decoders=all --enable-crypto --enable-plaintext-editor-only --enable-extensions=cookie,xml-rpc,xmlextras,p3p,pref,transformiix,universalchardet,typeaheadfind,webservices,inspector,negotiateauth --without-system-nspr --with-system-jpeg --with-system-zlib --with-system-png --with-system-mng --enable-default-toolkit=gtk2 --enable-single-profile --disable-profilesharing --with-dist-prefix=/it/sw/www/obj/mozilla/firefox-1.0/mozilla/dist --with-mozilla --cache-file=.././config.cache --srcdir=. loading cache .././config.cache checking host system type... sparc-sun-solaris2.9 checking target system type... sparc-sun-solaris2.9 checking build system type... sparc-sun-solaris2.9 checking for whoami... (cached) /it/sw/gnutools/bin/whoami checking for c++... (cached) /opt/SUNWspro/bin/CC checking whether the C++ compiler (/opt/SUNWspro/bin/CC -xO4 -xarch=v8plusa -xtarget=ultra -xbuiltin=%all -xstrconst -mt -L/it/sw/gnu/lib -L/it/sw/misc/lib -L/it/sw/X11/lib -L/it/sw/graphics/lib -L/it/sw/www/lib -L/it/sw/gnome/2.8/lib -L/usr/dt/lib -L/usr/openwin/lib -R/usr/lib:/it/sw/gnu/lib:/it/sw/misc/lib:/it/sw/X11/lib:/it/sw/graphics/lib:/it/sw/www/lib:/it/sw/gnome/2.8/lib) works... no configure: error: installation or configuration problem: C++ compiler cannot create executables. configure: error: ./configure failed for nsprpub *** Fix above errors and then restart with "gmake -f client.mk build" gmake: *** [/it/sw/www/obj/mozilla/firefox-1.0/mozilla/Makefile] Error 1
Assignee: bryner → nobody
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: SunOS → All
Product: Firefox → Core
QA Contact: asa → build-config
Hardware: Sun → All
Version: unspecified → Trunk
Attaching a patch so that we can request checkin approval.
Assignee: nobody → cls
Status: NEW → ASSIGNED
Attachment #180910 -
Flags: review+
Attachment #180910 -
Flags: approval1.8b2?
Comment 2•19 years ago
|
||
Comment on attachment 180910 [details] [diff] [review] patch a=asa
Attachment #180910 -
Flags: approval1.8b2? → approval1.8b2+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta2
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•