Closed Bug 271313 Opened 20 years ago Closed 20 years ago

nsMemory::HeapMinimize() crashes

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: benjamin)

References

Details

(Keywords: crash, regression)

Attachments

(1 file, 1 obsolete file)

regression caused by bug 267767
Attachment #166814 - Flags: review?(bsmedberg)
Comment on attachment 166814 [details] [diff] [review]
Puts sFlushLock in the NS_MEMORY_FLUSHER_THREAD ifdef

Actually, darin was wrong when he asked me to #ifdef this in the first place.
This lock is needed even if we don't use the memory-flusher thread, since
memory-flushing can be forced from client code or out-of-memory situations. The
real solution is not to #ifdef any of the sFlushLock/sIsFlushing calls.
Attachment #166814 - Flags: review?(bsmedberg) → review-
Keywords: crash, regression
Assignee: dougt → bsmedberg
Attachment #166814 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Comment on attachment 166846 [details] [diff] [review]
Move the #ifdef so the lock is always used

Darin or dougt, fell free to review.
Attachment #166846 - Flags: review?(darin)
Comment on attachment 166846 [details] [diff] [review]
Move the #ifdef so the lock is always used

r=darin

of course ;-)
Attachment #166846 - Flags: review?(darin) → review+
*** Bug 271382 has been marked as a duplicate of this bug. ***
fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Severity: normal → critical
*** Bug 271605 has been marked as a duplicate of this bug. ***
Depends on: 267767
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: