Closed
Bug 271313
Opened 20 years ago
Closed 20 years ago
nsMemory::HeapMinimize() crashes
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: benjamin)
References
Details
(Keywords: crash, regression)
Attachments
(1 file, 1 obsolete file)
595 bytes,
patch
|
darin.moz
:
review+
|
Details | Diff | Splinter Review |
regression caused by bug 267767
Reporter | ||
Comment 1•20 years ago
|
||
Reporter | ||
Updated•20 years ago
|
Attachment #166814 -
Flags: review?(bsmedberg)
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 166814 [details] [diff] [review] Puts sFlushLock in the NS_MEMORY_FLUSHER_THREAD ifdef Actually, darin was wrong when he asked me to #ifdef this in the first place. This lock is needed even if we don't use the memory-flusher thread, since memory-flushing can be forced from client code or out-of-memory situations. The real solution is not to #ifdef any of the sFlushLock/sIsFlushing calls.
Attachment #166814 -
Flags: review?(bsmedberg) → review-
Updated•20 years ago
|
Keywords: crash,
regression
Assignee | ||
Comment 3•20 years ago
|
||
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 166846 [details] [diff] [review] Move the #ifdef so the lock is always used Darin or dougt, fell free to review.
Attachment #166846 -
Flags: review?(darin)
Comment 5•20 years ago
|
||
Comment on attachment 166846 [details] [diff] [review] Move the #ifdef so the lock is always used r=darin of course ;-)
Attachment #166846 -
Flags: review?(darin) → review+
*** Bug 271382 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 7•20 years ago
|
||
fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Severity: normal → critical
*** Bug 271605 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•