Closed Bug 271955 Opened 20 years ago Closed 20 years ago

"empty" table cells don't include borders in size even when 'empty-cells: show'

Categories

(Core :: Layout: Tables, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8alpha6

People

(Reporter: dbaron, Assigned: dbaron)

References

()

Details

(Keywords: css2, Whiteboard: [patch])

Attachments

(1 file)

In http://dbaron.org/css/test/intrinsic/block-width-max , the third of the four
boxes is 4 pixels narrower than all the others.  This is because the intrinsic
sizing of the table cells determines that the cell is "empty" (I'm not sure
whether that's correct, but that's another bug) and therefore doesn't add in the
width of the borders.  The code that accounts for cells being smaller because of
lack of borders needs to check the 'empty-cells' property.
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha6
Attached patch patchSplinter Review
Perhaps I should also rename |contentEmptyBeforeReflow| to
|noBorderBeforeReflow|?
Attachment #167169 - Flags: superreview?(roc)
Attachment #167169 - Flags: review?(bernd.mielke)
Comment on attachment 167169 [details] [diff] [review]
patch

If you like to rename it its OK with me. The whole empty cell code is a
nightmare and needs to be rewritten but thats another story.
Attachment #167169 - Flags: review?(bernd.mielke) → review+
Attachment #167169 - Flags: superreview?(roc) → superreview+
Fix checked in to trunk, 2004-11-30 19:50 -0800.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 210710 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: