Closed
Bug 272830
Opened 20 years ago
Closed 20 years ago
to small row group is not pushed on next page
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Assigned: bernd_mozilla)
Details
(Keywords: testcase)
Attachments
(2 files, 1 obsolete file)
6.17 KB,
text/html
|
Details | |
4.46 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
load testcase in print preview see that the second page is empty one should be able to read last line. This is probably a dupe but I can't find it. I will attach soon.
Attachment #167668 -
Attachment is patch: false
Attachment #167668 -
Attachment mime type: text/plain → text/html
Attachment #167669 -
Attachment is obsolete: true
Attachment #167924 -
Flags: superreview?(bzbarsky)
Attachment #167924 -
Flags: review?(bzbarsky)
Comment 4•20 years ago
|
||
It'll take me a bit to get to this -- my net connection is spotty.... :(
Comment 5•20 years ago
|
||
Comment on attachment 167924 [details] [diff] [review] revised patch >Index: nsTableFrame.cpp >+ aDesiredSize.height = borderPadding.bottom + GetCellSpacingY() + >+ lastChildReflowed->GetRect().YMost(); Why is this still adding in the cellspacing? I don't think it should... r+sr=bzbarsky with that fixed or a comment explaining why it's correct.
Attachment #167924 -
Flags: superreview?(bzbarsky)
Attachment #167924 -
Flags: superreview+
Attachment #167924 -
Flags: review?(bzbarsky)
Attachment #167924 -
Flags: review+
the row groups are inset at the top by a border padding and a cellspacing this is reflected in the YMost. But a table has the borderpadding bottom and another cellspacing below the table and this, as the cellspacing above the row group not included (see CSS 2.1 "Next is the layer containing the row groups. Each row group extends from the top left corner of its topmost cell in the first column to the bottom right corner of its bottommost cell in the last column."). So I believe the patch is correct.
Comment 7•20 years ago
|
||
Oh, if we're putting cellspacing below the last lowgroup then the patch is in fact correct...
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 9•17 years ago
|
||
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/reftests/printing/reftest.list&rev=1.1
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•