Closed Bug 272856 Opened 20 years ago Closed 20 years ago

Subject or Sender contains (searchbox) does nothing

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mcsmurf, Assigned: emaijala+moz)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Patch v1.1
1.09 KB, patch
neil
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review 
To reproduce:
1. Go to any mail/news folder/group
2. Enter something in Subject or Sender contains

Notice nothing happens, in JS Console only
Error: gSearchInput has no properties
Source File: chrome://messenger/content/searchBar.js
Line: 188

Happens with current cvs trunk build.
Version: unspecified → Trunk
Maybe the bugfix for Bug 203386 exposed this bug?
Yes, it looks like the viewDebug call was depending on FocusRingUpdate_Mail
calling GetSearchInput() and therefore indirectly setting gSearchInput.
OS: Windows 2000 → All
Assignee: sspitzer → emaijala
Attached patch Proposed patch (obsolete) — — Splinter Review 
Let's initialize the search bar before trying to use it.
Attachment #168023 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 168023 [details] [diff] [review]
Proposed patch

Looking at initializeSearchBar I don't think we should be calling it all the
time... particularly when the search bar is blank.
Attachment #168023 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attached patch Patch v1.1 — — Splinter Review 
Ok, how about this approach?
Attachment #168023 - Attachment is obsolete: true
Attachment #168026 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 168026 [details] [diff] [review]
Patch v1.1

Assuming I'm looking at the same function, getDocumentElements doesn't seem to
set gSearchInput...
Attachment #168026 - Flags: review?(neil.parkwaycc.co.uk) → review-
Comment on attachment 168026 [details] [diff] [review]
Patch v1.1

I'll try again :)

It does call GetSearchInput() which initializes gSearchInput. I could of course
just call GetSearchInput() as some others in that file seem to do. Would that
be somehow better?
Attachment #168026 - Flags: review- → review?(neil.parkwaycc.co.uk)
Comment on attachment 168026 [details] [diff] [review]
Patch v1.1

Sorry for the oversight, was looking at the wrong searchBar.js :-[ This looks
ok but I can't test it myself at the moment.
Comment on attachment 168026 [details] [diff] [review]
Patch v1.1

this works for me.
Attachment #168026 - Flags: superreview+
Comment on attachment 168026 [details] [diff] [review]
Patch v1.1

as david says it works...
Attachment #168026 - Flags: review?(neil.parkwaycc.co.uk) → review+
Fxi checked in to trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Verified FIXED with both POP3 and IMAP accounts using build 2005-01-17-07 on
Windows XP Seamonkey trunk.
Status: RESOLVED → VERIFIED
*** Bug 277884 has been marked as a duplicate of this bug. ***
Blocks: 286367
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: