27316 - fix windows makefiles so outside people can do releases without splitsym

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Dawn Endico]

The MOZILLA_OFFICAL variable needs to be set to create packages with the
build date set, however it also is set up to create fullcircle builds which
require splitsym.exe. Either the two processes should be split up or
splitsym.exe should be made available for everyone and added to the list
of requirements. Not sure if it is free or not.

This is blocking people from doing mathml builds for windows.

Comment 1

[cls]

windows. reassigning to leaf.

Comment 2

[Dawn Endico]

Attachment: add MOZILLA_FULLCIRCLE flag

Comment 3

[Dawn Endico]

this worked for me building the mathml build. it set the build date
properly. It still needs to be tested doing fullcircle builds

Comment 4

[Dawn Endico]

Attachment: patch - MOZILLA_FULLCIRCLE no longer sets MOZILLA_OFFICIAL

Comment 5

[Daniel (Leaf) Nunes]

I'm a big loser... dawn can you repost the diffs with diff -c or diff -u?

Comment 6

[Dawn Endico]

Attachment: patch with diff -u

Comment 7

[Chris Yeh]

mass re-assign of all bugs where i was listed as the qa contact

Comment 8

[Jon Granrose]

this should be a simple change, but not urgent for moz 1.0 so setting 1.1.

Comment 9

[Dawn Endico]

roger, is this still an issue?

Is mathml still blocked? Apparently not because i've seen win32 mathml builds.
Is this patch completely rotted or is it worth checking in? 

Comment 10

[rbs]

I am not sure.

Do you know if they apply the patch before their builds? Since it is documented 
that the patch has to be applied as a workaround for official releases, maybe 
they are just applying the patch. Maybe you could ask them to try another build 
without applying the patch. This way, the answer will be known for sure.

Comment 11

[Daniel (Leaf) Nunes]

Index: makefile.win
===================================================================
RCS file: /cvsroot/mozilla/makefile.win,v
retrieving revision 3.102
diff -u -r3.102 makefile.win
--- makefile.win        2001/05/02 05:03:41     3.102
+++ makefile.win        2001/05/09 23:14:25
@@ -162,7 +162,7 @@
 splitsymbols:
 !if defined(MOZILLA_OFFICIAL)
 !if defined(FIND)
-!if "$(SPLITSYM)" != ""
+!if exist($(SPLITSYM))
        echo splitting symbols out of binaries
        cd $(MOZ_SRC)\mozilla
        $(FIND) $(DIST:\=/) -name "*.dll" -exec $(SPLITSYM) {} ;
@@ -170,7 +170,7 @@
        $(FIND) $(DIST:\=/) -name "*.EXE" -exec $(SPLITSYM) {} ;
 
 !else
-        echo No splitsym defined.
+        echo No splitsym defined, or does not exist.
 !endif
 !else
         echo No find defined.

a better patch.

Comment 12

[Daniel (Leaf) Nunes]

i need an r= from someone, then i'll seek an sr from cls

Comment 13

[Ben Bucksch (:BenB)]

Index: config/config.mak
===================================================================
RCS file: /cvsroot/mozilla/config/config.mak,v
retrieving revision 3.115
diff -u -u -w -r3.115 config.mak
--- config.mak 2001/06/20 20:17:41 3.115
+++ config.mak 2001/07/08 19:42:32
@@ -337,6 +342,7 @@
 PERL = perl.exe
 
 #if MOZILLA_OFFICIAL is set, then define splitsym
+#XXX bug 27316?
 !if defined (MOZILLA_OFFICIAL)
 SPLITSYM = $(MOZ_TOOLS)\bin\splitsym
 !endif

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

I don't think it's really reasonable to release 1.0 without this fix.  Nominating.

Comment 15

[Jon Granrose]

bug cleanup - all leaf's bugzilla bugs should be assigned to [e-mail]
(not [e-mail]), now and any future bugs created.

this should be a one time change, apologies for the spam.

Comment 16

[Daniel (Leaf) Nunes]

the newest instructions for building a distribution have people turn of building
the debugging symbols, and avoid the build targets that fail without splitsym
(which isn't necessary if you don't build debugging symbols, anyway).

marking fixed.