273447 - create a new import of libical

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

Upgrading the current copy of libical is no real fun, because of the local patches.
We could just create a new import somewhere in /mozilla/calendar. libical is mpl
now, so it doesn't need to be in other-licenses anymore.

We can then apply needed local patches to the new copy.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Import is done, but not enabled yet. see mozilla/calendar/libical.

Comment 2

[Andy Willis (abwillis)]

Since mozilla/calendar/libical was added I am unable to build calendar on OS/2. 
I get:
-MD,.deps/icaldirset.pp E:/cvs/work/mozilla/other-licenses/libical/src/libicalss
/icaldirset.c
E:/cvs/work/mozilla/other-licenses/libical/src/libicalss/icaldirset.c:511: confl
icting types for `icaldirset_add_component'
E:/cvs/work/mozilla/other-licenses/libical/src/libicalss/icaldirset.h:55: previo
us declaration of `icaldirset_add_component'
E:/cvs/work/mozilla/other-licenses/libical/src/libicalss/icaldirset.c:605: confl
icting types for `icaldirset_remove_component'
E:/cvs/work/mozilla/other-licenses/libical/src/libicalss/icaldirset.h:56: previo
us declaration of `icaldirset_remove_component'
make.exe[5]: *** [icaldirset.o] Error 1
make.exe[5]: Leaving directory `E:/cvs/work/mozilla/obj/other-licenses/libical/s
rc/libicalss'

There have been no changes to the other-licenses version since around May as I
can tell. My guess is this is related but if it isn't enable yet I don't know why.

Andy 

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

checked in a patch to disable building old libical:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/other-licenses/libical&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.4&rev2=1.5&root=/cvsroot
should help with that last problem.

Comment 4

[Andy Willis (abwillis)]

Thanks, that patch did fix it.
Andy

Comment 5

[Marc Bejarano]

*** Bug 263515 has been marked as a duplicate of this bug. ***

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

This bug is fixed, I believe.

Comment 7

[Marc Bejarano]

is the other-licenses version still there?  if so, should it be?

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!