Closed
Bug 273611
Opened 20 years ago
Closed 20 years ago
Add end of list marker to SECErrorCodes enum in secerr.h
Categories
(NSS :: Libraries, enhancement, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.10
People
(Reporter: nelson, Assigned: nelson)
Details
Attachments
(1 file)
961 bytes,
patch
|
saul.edwards.bugs
:
review+
wtc
:
superreview+
|
Details | Diff | Splinter Review |
An NSS user writes: In sslerr.h the error code enum ends with: SSL_ERROR_END_OF_LIST /* let the c compiler determine the value of this. */ this allows consumer code to check whether the count of error codes has changed from version to version. There is no analogous end marker in secerr.h though. Please add one so that consumer code won't miss new error messages that get added.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 168178 [details] [diff] [review] add end-of-list symbol Saul, please review.
Attachment #168178 -
Flags: review?(saul.edwards.bugs)
Comment 4•20 years ago
|
||
Comment on attachment 168178 [details] [diff] [review] add end-of-list symbol Spacing look funny before/after the equals sign. Otherwise OK.
Attachment #168178 -
Flags: review?(saul.edwards.bugs) → review+
Assignee | ||
Updated•20 years ago
|
Priority: -- → P2
Target Milestone: --- → 3.10
Assignee | ||
Comment 5•20 years ago
|
||
Checking in secerr.h; /cvsroot/mozilla/security/nss/lib/util/secerr.h,v <-- secerr.h new revision: 1.17; previous revision: 1.16 Thanks for the review, Saul. I fixed the whitespace and checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Attachment #168178 -
Flags: superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•