Open
Bug 273968
Opened 20 years ago
Updated 2 years ago
"View page source" on "xul" error page re-renders error page in view source window, instead of showing source
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
NEW
People
(Reporter: Biesinger, Unassigned)
References
Details
Attachments
(2 files)
1.11 KB,
patch
|
Details | Diff | Splinter Review | |
63.57 KB,
image/png
|
Details |
"View page source" on "xul" error page re-renders error page in view source window, instead of showing source. since I don'T think we care much about showing the error page source, we should probably just disable the menuitem...
Comment 1•19 years ago
|
||
fyi, it doesn't happen with "view selection source".
Comment 2•19 years ago
|
||
Of course -- "view selection source" doesn't need to try to actually get the source or anything like that.
Comment 3•19 years ago
|
||
Testing on Mac OS X, view page source shows the source of the last page (which may be about:blank) and view selection source shows the source of the error page. Both should just be disabled.
Comment 4•19 years ago
|
||
*** Bug 300627 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 5•19 years ago
|
||
this'd show the error page source in view source, but it was vetoed
(In reply to comment #5) > Created an attachment (id=190311) [edit] > patch to show error page source > > this'd show the error page source in view source, but it was vetoed IMO there's nothing wrong with showing the actual source of the error page.. you can do this in IE too.
Comment 7•19 years ago
|
||
The pref "browser.xul.error_pages.enabled" is only checked within nsDocShell::Create(). Changing it within the current tab seems that it is not triggered. http://lxr.mozilla.org/seamonkey/source/docshell/base/nsDocShell.cpp#3383
Reporter | ||
Comment 8•19 years ago
|
||
docshell should probably add itself as pref observer (nsIPrefBranch2::AddObserver) for that pref. note that it should not overwrite disabling of error pages via SetUseErrorPages(PR_FALSE).
That patch might have been vetoed, but the current behaviour (reopen the error page with an empty error URI) is stupid.
Comment 10•19 years ago
|
||
Strange.. and hard to reproduce, but for some reason on a Network Timeout error page, it showed the source of the previous page.
Comment 11•19 years ago
|
||
*** Bug 311500 has been marked as a duplicate of this bug. ***
Comment 12•19 years ago
|
||
*** Bug 303448 has been marked as a duplicate of this bug. ***
Comment 13•19 years ago
|
||
Without comments.
Comment 14•19 years ago
|
||
Im not sure that my problem is same, but I do the happy screenshot ( https://bugzilla.mozilla.org/attachment.cgi?id=207707 ). The most happy think is progress bar in View Source window. Yes I think tat viewing of source code of error page is stupid (I will not try this anytime) but I think :"That is a nice page. How is writed ???".
Comment 15•19 years ago
|
||
We know what the problem is. Please stop spamming the bug, ok? Unless you're planning to post a patch to fix it.
Comment 17•17 years ago
|
||
cross-posting my comment from bug 397937: > Bug 273968 must be either invalid or wontfix. If you actually can't reach a > server, you can't view the source of a page -- so view-source fails, and the > error page makes sense again. You could view the source of the error page, but > I don't know what that would be useful for. It would only confuse Web > developers. Those who are really interested in the Firefox source can find or > inspect it elsewhere. Disabling the menu item would be an option, but of course there are other ways to tell Firefox to view the source of a page.
Comment 18•17 years ago
|
||
(In reply to comment #17) > Disabling the menu item would be an option, but of course there are other ways > to tell Firefox to view the source of a page. That would be an option. But than the menu item and the shortcut has to be disabled. Other ways which are not easily reachable for normal users shouldn't be too necessary to fix? Or which possibilities do you have in mind?
Comment 19•17 years ago
|
||
(In reply to comment #18) > Other ways which are not easily reachable for normal users shouldn't > be too necessary to fix? Or which possibilities do you have in mind? The "view-source" scheme, which is reasonably popular. But that's not really a problem. I, at least, am fine with the current behavior. Bug 393002 should be fixed though.
Comment 20•17 years ago
|
||
Alternatively we could disable error pages in the view source window.
Comment 21•17 years ago
|
||
(In reply to comment #20) > Alternatively we could disable error pages in the view source window. What do you want to display instead?
Updated•17 years ago
|
OS: Linux → All
QA Contact: adamlock → docshell
Hardware: PC → All
Comment 22•16 years ago
|
||
Per bug 431955 steps: [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008050206 Minefield/3.0pre] (nightly) (W2Ksp4) Described behavior, plus Error in Error Console {{ Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMLocation.hostname]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: about:neterror?e=nssBadCert&u=view-source%3Ahttps%3A//www.gmail.com/&c=&d=www.gmail.com%20uses%20an%20invalid%20security%20certificate.%0A%0AThe%20certificate%20is%20only%20valid%20for%20%3Ca%20id%3D%22cert_domain_link%22%20title%3D%22mail.google.com%22%3Email.google.com%3C/a%3E%0A%0A%28Error%20code%3A%20ssl_error_bad_cert_domain%29%0A :: addDomainErrorLink :: line 223" data: no] }} [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008050202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) ViewSource window displays an alert dialog {{ Alert www.gmail.com:443 uses an invalid security certificate. The certificate is only valid for <a id="cert_domain_link" title="mail.google.com">mail.google.com</a> (Error code: ssl_error_bad_cert_domain) }} and does not load anything. SeaMonkey' behavior seems "better", except for the |<a>| tag, which doesn't make sense in a dialog.
Reporter | ||
Updated•12 years ago
|
Assignee: cbiesinger → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•