274280 - preference for sending unsent messages disregarded on startup: always asks

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Thomas Hettenhausen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Thunderbird does not have that kind of line, it is version 1.0 (20041206) - from said dialog

Whenever I start Thunderbird 1.0, it asks me whether I want to send the messages
which are in my Unsent Messages folder as soon as I am online.
Via Tools - Options - Advanced, I checked that I do NOT want to sent them,
instead of "Ask me", so I clearly do not want to be asked. I also always start
the application in online mode, since I have 24/7 internet access, so the
question is superflous and annoying.
Changing the line user_pref("offline.send.unsent_messages", x); with x either 0,
1 or 2 manually in prefs.js does not change the behaviour either.

Reproducible: Always
Steps to Reproduce:
1. set up IMAP email account
2. set preferences so that you do not want to send unsent messages when going
from offline to online
3. restart Thunderbird

Actual Results:  
get asked if you want to sent unsent messages

Expected Results:  
should not have shown the dialog box

This started happening with the 1.0 version, was not in 0.9.
No extensions installed, standard theme.
Pretty annoying though. Might go back to last version before 1.0 because of this.

Comment 1

[Thomas Hettenhausen]

Bug 224671 might be related, since it is the exact opposite of this bug.

Comment 2

[Mike Cowperthwaite]

Reproduced with TB 1.0 and TB 1.0+0222, Win2K.  

On program startup online, prompt appears regardless of setting of the 
preference.

On program already running, and going online, if you haven't already been asked 
once about this behavior, you will be prompted if the Preference is No *or* Ask 
Me.  And, this prompt features an Always Ask Me checkbox which is checked, 
regardless of the state of the preference.  But: Once you have selected either 
Send or Don't Send, the preference will be followed on subsequent online actions 
(and the preference will be set according to the state of the Always Ask 
checkbox on the prompt).

However, answering the prompt from the Going Online action does not affect the 
behavior of the Starting Up action.

Maybe this is by design, but it seems needlessly complex, even obscure.


(In reply to comment #1)
> Bug 224671 might be related, since it is the exact opposite of this bug.

That bug is a dupe of bug 232452, which has been fixed; but that fix didn't 
cause this problem, assuming you're correct in your observation that this 
started after 0.9.

Comment 3

[Mike Cowperthwaite]

*** Bug 287735 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Cowperthwaite]

*** Bug 326905 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Cowperthwaite]

*** Bug 323994 has been marked as a duplicate of this bug. ***

Comment 6

[Magnus Melin [:mkmelin]]

Taking.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (tb + sm)

This checks the pref before asking.

Comment 8

[David :Bienvenu]

Comment on attachment 231291 [details] [diff] [review]
proposed fix (tb + sm)

thanks for the patch, Magnus.  I don't agree with this bug 100% since starting up isn't necessarily the same as going online, but since the user has chosen not to be reminded, which is not the default behaviour, it's better to err on the side of not bothering the user.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/base/resources/content/msgMail3PaneWindow.js 	1.293
mozilla/mail/base/content/msgMail3PaneWindow.js 	1.92

Comment 10

[Mike Cowperthwaite]

Verified fixed with TB 3a1-0826.  Is this worth getting into TB 2.0/SM 1.5?

Comment 11

[Scott MacGregor]

not a blocker, but am interested in patch approval

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/base/content/msgMail3PaneWindow.js 	1.70.2.28
mozilla/mailnews/base/resources/content/msgMail3PaneWindow.js 	1.282.2.10

Comment 13

[Mike Cowperthwaite]

V fixed on 2b1-1018, thank you!