276152 - static build on cygwin/mingw broken (should not link Urlmon)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Hans-Andreas Engel]

Building a static version of firefox (probably the same for mozilla) does not
work on a standard cygwin installation; it fails while linking firefox.exe.

The linker cannot find "-lUrlmon," since  MinGW currently does not provide the
"Urlmon" library (see http://cvs.sourceforge.net/viewcvs.py/mingw/w32api/lib/).

This problem can be fixed easily by removing "Urlmon" from STATIC_EXTRA_LIBS in
config/static-config.mk.  It seems that this library is not used at all (I am
using --disable-accessibility and --disable-activex).

Comment 1

[Hans-Andreas Engel]

Attachment: removing "Urlmon" from statically linking

removing "Urlmon" from statically linking

enables static builds on cygwin

Comment 2

[Hans-Andreas Engel]

Is the "Urlmon" library used when building with MSVC?  If not, we could remove
it generally.  Maybe also #include <urlmon.h> could be removed.

Comment 3

[Benjamin Smedberg]

Hans-Andreas, you're going to have to answer those kinds of questions before I
can review this, or find somebody who can.

Comment 4

[Hans-Andreas Engel]

I am not asking for a review on this patch.  (I only described a problem, the
reason why it appears, and how it could be fixed on cygwin.)

Benjamin, I thought you might be interested in this issue and added you as CC;
sorry if this caused a misunderstanding.

Indeed, I would like to find someone who has MSVC (I don't) and could try if
linking firefox/mozilla without the "Urlmon" library works.  Otherwise, this
library can only be removed for cygwin, i.e., a more sophisticated patch to
static-config.mk is required.

Comment 5

[cls]

Attachment: remove all urlmon references

This patch removes all core urlmon references (except the activex plugin) from the tree.  I tested it with mingw gcc & the free vc71 builds.

Comment 6

[Hans-Andreas Engel]

Great!  Chris, thank you for fixing this and for testing.