276679 - nsHistoryLoadListener.cpp in source tree, but unused

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Crispin Flowerday (not receiving bug mail)]

While trying to work out if nsIBrowserHistory::HidePage was ever actually used,
I noticed that both:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/history/src/nsHistoryLoadListener.cpp
http://lxr.mozilla.org/seamonkey/source/toolkit/components/history/src/nsHistoryLoadListener.cpp

are not used, they are not compiled (missing from the Makefile.in) and in fact
haven't been updated to the new nsIBrowserHistory API (nsIURI rather than strings).

Possibly they should be removed, and perhaps the nsIBrowserHistory::HidePage()
function as well.

Comment 1

[Benjamin Smedberg]

r=me for removing the files. IIRC there were external embedders who were using
hidePage, but I don't remember why.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Removing xpfe/components/history/src/nsHistoryLoadListener.cpp;
/cvsroot/mozilla/xpfe/components/history/src/nsHistoryLoadListener.cpp,v  <-- 
nsHistoryLoadListener.cpp
new revision: delete; previous revision: 1.8
done
Removing toolkit/components/history/src/nsHistoryLoadListener.cpp;
/cvsroot/mozilla/toolkit/components/history/src/nsHistoryLoadListener.cpp,v  <--
 nsHistoryLoadListener.cpp
new revision: delete; previous revision: 1.3
done