Open
Bug 277544
Opened 20 years ago
Updated 2 years ago
[Mac] ESC shouldn't close windows (other than dialogs)
Categories
(Firefox :: Keyboard Navigation, defect, P4)
Tracking
()
NEW
People
(Reporter: asaf, Unassigned)
Details
(Keywords: platform-parity)
Many firefox / toolkit windows have the following keybinding defined: <key keycode="VK_ESCAPE" command="cmd_close"/> On mac, only accel+w should close normal windows, We should verify Accel+W is defined for every window and #ifndef esc keybindings. ------- /me notes himself: http://lxr.mozilla.org/seamonkey/source/browser/base/content/pageInfo.xul#59 http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarksManager.xul#81 http://lxr.mozilla.org/seamonkey/source/mail/base/content/messageWindow.xul#98 http://lxr.mozilla.org/seamonkey/source/toolkit/components/console/content/console.xul#82 http://lxr.mozilla.org/seamonkey/source/toolkit/components/help/content/help.xul#126 http://lxr.mozilla.org/seamonkey/source/toolkit/components/viewsource/content/viewPartialSource.xul#104 http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/downloads/content/downloads.xul#90 http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/content/extensions.xul#73
Reporter | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.1
Reporter | ||
Updated•20 years ago
|
Component: OS Integration → Keyboard Navigation
Comment 1•20 years ago
|
||
Really, this is where we need to have an equivalent to dialogKeys defined instead of having to preprocess this in multiple files.
Comment 2•20 years ago
|
||
er, scratch that, dialogKeys is deprecated with the dialog widget. Either way, if its something we should have for all windows, we need to define this once :)
Reporter | ||
Updated•20 years ago
|
Summary: [Mac] ESC shouldn't close windows (other than sheets) → [Mac] ESC shouldn't close windows (other than dialogs)
Comment 3•20 years ago
|
||
See also Bug 199424 - "Accel+W should close any window that has a close-window widget, unless it has more than one tab open". I wonder if that bug should apply to dialog as well. I mean, it's not always easy to tell if a window is actually a dialog. We shouldn't expect users to guess when to press Esc and when to press Accel+W. It should either be visually obvious, or both keys should work when there's doubt. Prog.
Comment 4•20 years ago
|
||
Not really an accessibility bug. Removing Escape to close the dialog doesn't really make it more accessible.
Keywords: access
Reporter | ||
Updated•19 years ago
|
Priority: -- → P4
Reporter | ||
Updated•19 years ago
|
Target Milestone: Firefox1.1 → ---
Comment 5•18 years ago
|
||
Removing uiwanted; there is a clearly requested design here, and this is more PP than anything else. Also, fwiw, the statement that ESC only closes dialogs on OS X is incomplete: ESC is used to close dialogs and "inspector" windows, which are always-on-top properties windows that have the minimize and expand buttons disabled.
Keywords: uiwanted
Reporter | ||
Updated•18 years ago
|
Assignee: bugs.mano → nobody
Status: ASSIGNED → NEW
QA Contact: os.integration → keyboard.navigation
Comment 6•18 years ago
|
||
I disagree with this bug. I want Esc to continue to close "Properties" and "Preferences" windows. Doing what I intend when I press a key is more important than consistency with other apps. And Mac apps seem to be about evenly split on whether Esc closes Preferences, anyway: * Yes: Safari, Terminal, Colloquy, VLC * No: TextEdit, TextWrangler, Smultron, Adium
Comment 7•15 years ago
|
||
like Jesse, i prefer Esc key to close Windows when there is nothing to save. But i find it to be inconsistent. Esc close in * main preferences window but not in: * allowed site - add-ons exceptions * and most sub-window of preferences, it seems bug listed here https://bugzilla.mozilla.org/show_bug.cgi?id=306197
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•