Closed
Bug 277587
Opened 20 years ago
Closed 19 years ago
nsSecureBrowserUIImpl's nsUIContext interface requestor doesn't give access to the dom window
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: jgmyers)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
1.08 KB,
patch
|
jgmyers
:
review+
roc
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
nsSecureBrowserUIImpl calls nsISecurityWarningDialogs with a nsIInterfaceRequestor which is gives out only nsIPrompt. The PSM default nsSecurityWarningDialogs implementation only needs the nsIPrompt; but I want to provide my own implementation of nsISecurityWarningDialogs and need to access the nsIDOMWindow to have a parent for my dialogues (I can get from nsIDOMWindow to the toplevel GtkWindow).
Reporter | ||
Comment 1•20 years ago
|
||
Reporter | ||
Comment 2•20 years ago
|
||
Comment on attachment 170696 [details] [diff] [review] make the interface requestor give out its nsIDOMWindow Asking for review...
Attachment #170696 -
Flags: review?(jgmyers)
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 170696 [details] [diff] [review] make the interface requestor give out its nsIDOMWindow You might want to just NS_ADDREF(mWindow) in order to avoid the cast.
Attachment #170696 -
Flags: review?(jgmyers) → review+
Assignee | ||
Updated•20 years ago
|
Assignee: kaie → jgmyers
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 4•20 years ago
|
||
NS_ADDREF(mWindow) doesn't work since mWindow is a nsCOMPtr and ::AddRef is private. Can you suggest who I should ask for super-review?
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 170696 [details] [diff] [review] make the interface requestor give out its nsIDOMWindow Asking for superreview now...
Attachment #170696 -
Flags: superreview?(alecf)
Comment on attachment 170696 [details] [diff] [review] make the interface requestor give out its nsIDOMWindow we should land this no-risk patch for embedders
Attachment #170696 -
Flags: superreview?(alecf)
Attachment #170696 -
Flags: superreview+
Attachment #170696 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #170696 -
Flags: approval1.8b4? → approval1.8b4+
Comment 7•19 years ago
|
||
HEAD: Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp; /cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v <-- nsSecureBrowserUIImpl.cpp new revision: 1.49; previous revision: 1.48 done MOZILLA_1_8_BRANCH: Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp; /cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v <-- nsSecureBrowserUIImpl.cpp new revision: 1.48.2.1; previous revision: 1.48 done
Comment 8•19 years ago
|
||
See also bug 306288. How much of it does this fix? Please be more liberal with the Cc: list in future. Other people need to know what's going on.
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•