277650 - e4x: xml:lang attribute in XML literal causes error

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Martin Honnen]

Spidermonkey (at least when used in a Mozilla 1.8a nightly in a HTML page with
<script type="text/javascript; e4x=1">) on the following script
var xml = <root><text xml:lang="en">ECMAScript for XML</text></root>;
throws an error

Error: invalid XML namespace xml
Source File: http://home.arcor.de/martin.honnen/mozillaBugs/e4x/test2005010901.js
Line: 1, Column: 29
Source Code:
<parent xmlns=''><root><text xml:lang="en">ECMAScript for XML</text></root></parent>

Rhino processes the script without error and xml:lang attributes are quite
common and in my view should be possible in XML so Spidermonkey should process
the script without any error.

Test script is here:
<http://home.arcor.de/martin.honnen/mozillaBugs/e4x/test2005010901.js>

HTML test case using that script is here:
<http://home.arcor.de/martin.honnen/mozillaBugs/e4x/xmllangAttribute.html>

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

Thanks to dbaron for the XML spec pointers (hint: don't look at the original
"1.0" era specs -- you need the "11" [for "1.1"] at the end of the spec's
filename).

/be

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 170855 [details] [diff] [review]
proposed fix

r=shaver

Comment 3

[Brendan Eich [:brendan]]

Fixed, thanks.

/be

Comment 4

[Martin Honnen]

Verified fixed with Mozilla 1.8b (Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8b) Gecko/20050122)

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: e4x/Regress/regress-277650.js

Martin, with your permission this will be included in the javascript test
library.

Comment 6

[Bob Clary [:bc] (inactive)]

e4x/Regress/regress-277650.js checked in.