Closed
Bug 277879
Opened 20 years ago
Closed 1 month ago
Visual corruption when parent of a sheet is resized
Categories
(Core Graveyard :: Widget: Mac, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: the_great_spam_bin, Unassigned)
References
Details
Attachments
(1 file)
801 bytes,
patch
|
danm.moz
:
review-
|
Details | Diff | Splinter Review |
When the parent window of a sheet is resized, the content of that window is never resized along with it resulting in visual corruption. The reason for this is that since the sheet parent window is not enabled, Gecko NS_SIZE events are not passed along to its contents.
This fixes it by allowing events through even if the window is disabled. I haven't noticed any ill effects, but more testing would probably be helpful.
Attachment #170890 -
Flags: review?(sfraser_bugs)
Comment on attachment 170890 [details] [diff] [review] patch I don't have an OS X box to test on, so I can only offer guidelines. Ari's patch effectively hamstrings Mozilla's attempt to disable a window. Perhaps that doesn't hurt anything with sheets on OS X; perhaps the OS takes care of disabling the parent window. Event filtering was part of Mozilla's homespun window modality necessitated by OS 9. I'd rather see the filter modified to allow paint events into the disabled window, rather than all events as this patch does. But if OS X finally takes it upon itself to handle modality, and *not just for sheets* (because ideas like bug 136422 come and go), then feel free to chuck event filtering. If you go that route, I'd rather see a cleaner patch that doesn't leave little bits of the old code dangling useless.
Attachment #170890 -
Flags: review?(sfraser_bugs) → review-
Updated•19 years ago
|
Assignee: sfraser_bugs → joshmoz
Updated•19 years ago
|
QA Contact: mac
Comment 3•18 years ago
|
||
*** Bug 334081 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•