Closed Bug 277950 Opened 20 years ago Closed 20 years ago

[FIXr]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]

Categories

(Core :: XBL, defect, P2)

Product:
Core
Component:
XBL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8beta1

People

(Reporter: stefanh, Assigned: bzbarsky)

Details

(Keywords: crash, testcase)

Crash Data

Attachments

(3 files)

Testcase
405 bytes, application/xhtml+xml
Details
Crash log
21.30 KB, text/plain
Details
Just needs a null-check....
1.18 KB, patch
bryner
: review+
bryner
: superreview+
Details | Diff | Splinter Review 
Mozilla 2005010905, Mac OS X.

I seem to crash if I leave out the name attribute in the property element.
Testcase is on the way...
Attached file Testcase — 
Hmm, looks like Talkback isn't included in the mac nightlies anymore? Will
attach a OS X crash log. I do have TB3002288K from the same crash with Firefox
1.0, though.
Attached file Crash log — 

    
    

    
  
Here's the source of the testcase file:

<?xml version="1.0"?>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Testcase</title>
<xbl:bindings xmlns="http://www.mozilla.org/xbl"
  xmlns:xbl="http://www.mozilla.org/xbl">
  <binding id="test">
    <implementation>
      <property/>
    </implementation>
  </binding>
</xbl:bindings>
<style type="text/css">
  p{ -moz-binding: url(#test); }
</style>
</head>
<body>
<p></p>
</body>
</html>

Add 'name="foo"' to property and you will not crash.
Keywords: crash, 
          
            testcase

    
    

    
  


  
Assignee: hyatt → bzbarsky
Status: NEW → ASSIGNED

        Attachment #170975 -
        Flags: superreview?(bryner)

        Attachment #170975 -
        Flags: review?(bryner)

    
  
OS: MacOS X → All
Priority: -- → P2
Hardware: Macintosh → All
Summary: Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()] → [FIX]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]
Target Milestone: --- → mozilla1.8beta

        Attachment #170975 -
        Flags: superreview?(bryner)

        Attachment #170975 -
        Flags: superreview+

        Attachment #170975 -
        Flags: review?(bryner)

        Attachment #170975 -
        Flags: review+

    
  
Summary: [FIX]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()] → [FIXr]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]

    
    

    
  
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
v
Status: RESOLVED → VERIFIED

    
    

    
  
content/xbl/crashtests/277950-1.xhtml
http://hg.mozilla.org/mozilla-central/rev/b0337b6287f3
Flags: in-testsuite+
Crash Signature: [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: