278341 - [mozTXTToHTMLConv] A colon (:) after a URL in a message is recognized as part of the URL.

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Dmitry Nikiforov]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/125.5.5 (KHTML, like Gecko) Safari/125.12
Build Identifier: 

If there is a colon after a URL in a message - it is recognized by Thunderbird as part of the URL. For 
example. http://bugzilla.mozilla.org/index.html: would be a complete URL with a colon at the end and 
the link will be the same, which will generate an error. The same is true for combinations of symbols: 
",:", "::" etc. This is not true, if there's no file after the host name - http://bugzilla.mozilla.org: will 
generate a correct link to http://bugzilla.mozilla.org.

Reproducible: Always

Steps to Reproduce:
1. Send a message containing a URL with a file name and a colon right after it (e-mail, news)
2. When message arrived - check where the link points to - to just the URL or to the URL with the colon.

Actual Results:  
The link points to URL with colon.

Expected Results:  
The link should point to the URL only, colon should remain a part of plain text in the message.

Comment 1

[Doug Wright]

Taking a stab at a better component for this.

Comment 2

[Mike Cowperthwaite]

xref bug 218287, bug 133016

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 5

[Frank Wein [:mcsmurf]]

Reopening, this bug is still valid and a problem in MailNews.

Comment 6

[Ben Bucksch (:BenB)]

Attachment: Fix, v1

Patch, untested

Comment 7

[:aceman]

Attachment: unbittrotted patch and tested

Comment 8

[Ben Bucksch (:BenB)]

Comment on attachment 572600 [details] [diff] [review]
unbittrotted patch and tested

Yes, we should do it, exactly like that.

r=BenB

Comment 9

[Ben Bucksch (:BenB)]

Note that we wouldn't catch skype: or similar anymore as a URL, but I don't see any point in a URL like that, esp. in a recognizer (get the catch common cases, not edge cases). This example is purely theoretic, I don't know any concrete URL like that, and I agree the usecase mentioned in this bug is more important. I am just recording this for completeness, that we considered and rejected this edge case.

Comment 10

[David :Bienvenu]

Comment on attachment 572600 [details] [diff] [review]
unbittrotted patch and tested

only need one review for this

Comment 12

[Mark Banner (:standard8)]

Landed on mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/949db7aa6119

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/949db7aa6119