Closed
Bug 278467
Opened 20 years ago
Closed 19 years ago
String object (not literal string) as value to setParameter causes error.
Categories
(Core :: XSLT, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bedney, Assigned: peterv)
References
Details
Attachments
(1 file, 1 obsolete file)
2.39 KB,
text/html
|
Details |
It seems that using setParameter() with a String object as opposed to a literal string will cause the XSLT processor to give up with an error. In other words, this is bad: myProcessor = new XSLTProcessor(); myProcessor.setParameter(null,'foo',new String('bar')); Note that the following works: myProcessor.setParameter(null,'foo','bar'); Testcase is coming up. Cheers, - Bill
Reporter | ||
Comment 1•20 years ago
|
||
Run the test case. It works because the parameter is a string literal. Edit the JS in the transformIt() function in the head of the document and uncomment the line that assigns a String object to the parameter value. The transformation no longer works and gives an error in the JavaScript console.
Assignee | ||
Comment 2•20 years ago
|
||
So I could fix this in Transformiix, but I wonder if it wouldn't be better to have XPConnect handle this itself. XPCVariant::InitializeData (http://lxr.mozilla.org/seamonkey/source/js/src/xpconnect/src/xpcvariant.cpp#240) special-cases JS primitive types and JS arrays (and nsIJSID, nsIJSIID and nsIJSCID). Anything else just gets wrapped and stored as an nsISupports in the variant. Would it make sense to have some of the builtin JS classes converted into a specific nsVariant type (VTYPE_DOUBLE for Number, VTYPE_BOOL for Boolean, ...)?
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #171306 -
Attachment is obsolete: true
Assignee | ||
Comment 4•19 years ago
|
||
I'll do this as part of bug 248025. I'll convert all JS objects to string parameters.
Depends on: 248025
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 171306 [details]
Test case showing that using String 'objects' as opposed to literals doesn't work.
This doesn't crash in any way.
Attachment #171306 -
Attachment description: Test case showing that using String 'objects' as opposed to literals crashes the XSLT processor → Test case showing that using String 'objects' as opposed to literals doesn't work.
Assignee | ||
Comment 6•19 years ago
|
||
Fixed by patch in bug 248025, all JS objects are converted to string now.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•